Skip to content

Conversation

steve-calvert-glean
Copy link
Collaborator

@steve-calvert-glean steve-calvert-glean commented Aug 19, 2025

Code changes:

  • Removed device code flow support by deleting relevant functions and handling logic from the code, shifting from an OAuth-based approach to a direct token-based configuration method.

This change indicates a move away from using the device authorization model, which may streamline the configuration process by removing layers of checks and balances associated with OAuth device flows.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Build/CI pipeline changes
  • Other (please describe):

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual testing
  • Other (please describe):

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have checked for potential breaking changes and addressed them

Copy link
Member

@david-hamilton-glean david-hamilton-glean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests red but otherwise LGTM

@steve-calvert-glean steve-calvert-glean merged commit eb06356 into main Aug 21, 2025
3 checks passed
@steve-calvert-glean steve-calvert-glean deleted the remove-device-code branch August 21, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants