Skip to content

chore: adds documentation about data-tab-container-no-tabstop #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

chore: adds documentation about data-tab-container-no-tabstop #62

merged 1 commit into from
Oct 11, 2022

Conversation

andrialexandrou
Copy link
Contributor

@andrialexandrou andrialexandrou commented Oct 11, 2022 •
edited
Loading

I'm experimenting with how to surface API details, but for now a note in the docs may be good. What do you think?

Relates to github/accessibility-audits#2787 and github/accessibility#1897.

@andrialexandrou andrialexandrou requested a review from a team as a code owner October 11, 2022 10:44
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

keithamus
keithamus approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrialexandrou andrialexandrou merged commit e8d8a49 into main Oct 11, 2022
@andrialexandrou andrialexandrou deleted the aja/doc-tabstop branch October 11, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrialexandrou @primer-css @keithamus