chore: set build arg for publishing version #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the version build argument is set correctly during the Docker image build process, both in the build layer and via the GitHub Actions workflow.
- Converted cron and tag schedule values to use consistent double quotes.
- Updated YAML formatting for consistency.
- Added build-args to pass the version using the GitHub reference name.
Files not reviewed (1)
- Dockerfile: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version build arg needs to be passed through to the correct layer in the docker image build, and the build arg also needs to be passed through to the image build from the actions workflow.