Make `safe-outputs.add-comment` discussions permission opt-in by default by Copilot · Pull Request #39051 · github/gh-aw

Copilot · 2026-06-13T10:21:42Z

add-comment previously requested discussions: write unless explicitly disabled, which breaks in environments where Discussions permission is unavailable. This change flips the default so discussion-comment capability is only enabled when explicitly requested.

Permission default change
- Updated AddCommentsConfig semantics so discussions is opt-in.
- buildAddCommentPermissions now grants discussions: write only when discussions: true.
Behavior and expectation updates in tests
- Updated permission and integration tests to reflect the new default (discussions absent ⇒ no discussions permission).
- Updated consolidated safe-outputs and conclusion-job permission assertions impacted by add-comment defaults.
- Added focused tests to verify runtime add_comment tool-description behavior for both discussions: true and default-disabled cases.
Tooling/docs parity
- Updated safe-output tool descriptions (runtime and embedded JSON) and spec text to match new behavior:
  - default: no discussions permission
  - enable with safe-outputs.add-comment.discussions: true
- Updated safe-outputs MCP startup behavior so JavaScript dynamically rewrites the add_comment description to reflect available discussion permissions (including when reply_to_id discussion-threading support is advertised).

// before: nil meant discussions enabled
if config == nil || config.Discussions == nil || *config.Discussions {
    permMap[PermissionDiscussions] = PermissionWrite
}

// now: discussions is explicitly opt-in
if config != nil && config.Discussions != nil && *config.Discussions {
    permMap[PermissionDiscussions] = PermissionWrite
}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-06-13T10:24:33Z

@copilot the add-comment description should be dynamically updated to reflect the available permissions in JavaScript when starting the safe output MCP

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…scription Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-06-13T10:47:33Z

@copilot the add-comment description should be dynamically updated to reflect the available permissions in JavaScript when starting the safe output MCP

Implemented in 9a36f4d. The safe-outputs MCP startup now dynamically rewrites the add_comment tool description in JavaScript based on runtime permissions: it reflects whether discussion comments are enabled (discussions: true) or disabled by default, and only advertises reply_to_id discussion threading support when discussions permission is available.

github-actions · 2026-06-13T10:56:32Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #39051 does not have the 'implementation' label and has only 31 new lines in business logic directories (≤100 threshold), with no custom .design-gate.yml config.

Copilot

Pull request overview

This pull request flips safe-outputs.add-comment so discussions: write is no longer requested by default, making Discussions commenting explicitly opt-in (safe-outputs.add-comment.discussions: true). It updates the permission computation, test expectations, runtime tool description generation, and regenerated lock workflows to match the new default.

Changes:

Changed add-comment permission derivation so discussions: write is granted only when discussions: true.
Updated/added tests and tool-description logic to reflect the new default-disabled discussions behavior (including dynamic description rewriting).
Regenerated many .lock.yml workflows to drop discussions: write where it was only present due to the old default.

Show a summary per file

File	Description
pkg/workflow/add_comment.go	Makes discussions permission opt-in for add-comment and updates config semantics/docs.
pkg/workflow/safe_outputs_handler_registry.go	Emits `discussions` into handler config for add_comment.
pkg/workflow/safe_outputs_permissions_test.go	Updates permission expectation tests for new add-comment default (no discussions).
pkg/workflow/add_comment_discussions_integration_test.go	Updates integration expectations for discussions default/behavior.
pkg/workflow/notify_comment_test.go	Updates conclusion-job permission expectations around add-comment defaults.
pkg/workflow/compiler_safe_outputs_job_test.go	Adjusts consolidated safe_outputs job permission assertions impacted by add-comment defaults.
pkg/workflow/compiler_safe_outputs_config_test.go	Adds a boolean-field handler-config test for add_comment `discussions`.
pkg/workflow/compile_outputs_comment_test.go	Updates generated lock permissions substring assertion for new default.
pkg/workflow/js/safe_outputs_tools.json	Updates embedded add_comment tool description to reflect opt-in discussions.
actions/setup/js/safe_outputs_tools.json	Updates runtime tools source description for add_comment to reflect opt-in discussions.
actions/setup/js/generate_safe_outputs_tools.cjs	Dynamically rewrites add_comment description to reflect discussion capability.
actions/setup/js/generate_safe_outputs_tools.test.cjs	Adds tests for dynamic add_comment description behavior (enabled vs default-disabled).
docs/src/content/docs/specs/safe-outputs-specification.md	Updates add_comment tool schema description note for new default.
.github/workflows/workflow-health-manager.lock.yml	Removes `discussions: write` from job permissions where it was only due to old add-comment default.
.github/workflows/visual-regression-checker.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/unbloat-docs.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/test-quality-sentinel.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/technical-doc-writer.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/sub-issue-closer.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/static-analysis-report.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/stale-pr-cleanup.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-workflow-call.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-update-cross-repo-pr.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-test-tools.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-temporary-id.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-service-ports.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-project.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-pi.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-opencode.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-multi-pr.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-gemini.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-crush.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-create-cross-repo-pr.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-claude.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-ci.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-antigravity.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-agent-scoped-approved.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-agent-public-none.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-agent-public-approved.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-agent-all-none.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/smoke-agent-all-merged.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/scout.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/ruflo-backed-task.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/refiner.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/q.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/pr-triage-agent.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/pr-sous-chef.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/necromancer.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/mattpocock-skills-reviewer.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/issue-triage-agent.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/issue-monster.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/draft-pr-cleanup.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/discussion-task-miner.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/dev-hawk.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/design-decision-gate.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/dependabot-repair.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/daily-fact.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/daily-assign-issue-to-user.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/craft.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/contribution-check.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/cloclo.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/ci-doctor.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/brave.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/archie.lock.yml	Same: regenerated permissions without discussions write.
.github/workflows/approach-validator.lock.yml	Same: regenerated permissions without discussions write.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 65/65 changed files
Comments generated: 2

 ```json
 {
  "name": "add_comment",
-  "description": "Add a comment to an existing issue, pull request, or discussion. IMPORTANT: Comments are subject to validation constraints enforced by the MCP server - maximum 65536 characters for the complete comment (including footer which is added automatically), 10 mentions (@username), and 50 links. Exceeding these limits will result in an immediate error with specific guidance. NOTE: By default, this tool requires discussions:write permission. If your GitHub App lacks Discussions permission, set 'discussions: false' in the workflow's safe-outputs.add-comment configuration to exclude this permission.",
+  "description": "Add a comment to an existing issue, pull request, or discussion. IMPORTANT: Comments are subject to validation constraints enforced by the MCP server - maximum 65536 characters for the complete comment (including footer which is added automatically), 10 mentions (@username), and 50 links. Exceeding these limits will result in an immediate error with specific guidance. NOTE: By default, this tool does not require discussions:write permission. Set 'discussions: true' in the workflow's safe-outputs.add-comment configuration to enable discussion comments and request this permission.",
  "inputSchema": {


 				// Check permissions based on what safe-outputs are configured
-				// When add-comment is configured, it requires issues and discussions permissions
+				// When add-comment is configured by default, it requires issues permission
 				// (PR comments are issue comments, so only issues: write is needed, not pull-requests: write)
 				// When only missing_tool/noop is configured, minimal permissions are needed
 				if tt.addCommentConfig {


pelikhan · 2026-06-13T11:05:47Z

@copilot fix tests https://github.com/github/gh-aw/actions/runs/27464680988/job/81184992415

github-actions · 2026-06-13T11:10:07Z

@copilot review all comments and address unresolved review feedback.

Generated by 👨‍🍳 PR Sous Chef · 69.2 AIC · ⌖ 1.02 AIC · ⊞ 17.3K · ◷

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-06-13T11:15:42Z

@copilot fix tests https://github.com/github/gh-aw/actions/runs/27464680988/job/81184992415

Fixed in the latest commit. The TypeScript error was a missing parentheses in the JSDoc type cast on line 53 of generate_safe_outputs_tools.cjs — changed /** @type {Record<string, unknown>} */ addCommentConfig to /** @type {Record<string, unknown>} */ (addCommentConfig) so the cast is properly applied.

pelikhan · 2026-06-13T11:29:22Z

@copilot lint js

https://github.com/github/gh-aw/actions/runs/27465199608/job/81186252709

…ier strips Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-06-13T11:45:56Z

@copilot lint js

https://github.com/github/gh-aw/actions/runs/27465199608/job/81186252709

Fixed in the latest commit. The JSDoc inline cast (/** @type {...} */ expr) was being stripped by Prettier, which reintroduced the TypeScript error. Replaced it with in-operator narrowing — typeof addCommentConfig === "object" && addCommentConfig !== null && "discussions" in addCommentConfig && addCommentConfig.discussions === true — which satisfies both the TypeScript checker and Prettier without any casts.

Copilot AI and others added 2 commits June 12, 2026 21:10

Set add-comment discussions permission to opt-in

5787ae4

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Adjust consolidated safe-outputs permission tests for new default

1b855e3

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Jun 13, 2026

Copilot created this pull request from a session on behalf of pelikhan June 13, 2026 10:21 View session

Copilot started work on behalf of pelikhan June 13, 2026 10:25 View session

Copilot AI and others added 3 commits June 13, 2026 10:29

Plan review-feedback fix

3ea685d

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Dynamically reflect add-comment discussions capability in MCP tool de…

990fc1b

…scription Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Make add_comment MCP description reflect runtime discussions permission

9a36f4d

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan June 13, 2026 10:48

Copilot AI requested a review from pelikhan June 13, 2026 10:48

pelikhan marked this pull request as ready for review June 13, 2026 10:51

Copilot AI review requested due to automatic review settings June 13, 2026 10:51

Copilot started reviewing on behalf of pelikhan June 13, 2026 10:52 View session

github-actions Bot mentioned this pull request Jun 13, 2026

[aw] Test Quality Sentinel exceeded daily AI credits budget #39059

Open

Copilot AI reviewed Jun 13, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jun 13, 2026

[aw] No-Op Runs #38951

Open

Copilot started work on behalf of pelikhan June 13, 2026 11:09 View session

Fix TypeScript type cast in generate_safe_outputs_tools.cjs

7d13ed2

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan June 13, 2026 11:15

Copilot started work on behalf of pelikhan June 13, 2026 11:37 View session

Fix JS lint: use in-operator narrowing to avoid JSDoc cast that Prett…

bd2a85e

…ier strips Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan June 13, 2026 11:46

pelikhan merged commit e1cc4da into main Jun 13, 2026
37 checks passed

pelikhan deleted the copilot/update-add-comment-safe-outputs branch June 13, 2026 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `safe-outputs.add-comment` discussions permission opt-in by default#39051

Make `safe-outputs.add-comment` discussions permission opt-in by default#39051
pelikhan merged 7 commits into
mainfrom
copilot/update-add-comment-safe-outputs

Copilot AI commented Jun 13, 2026 •

edited

Loading

Uh oh!

pelikhan commented Jun 13, 2026

Uh oh!

Copilot AI commented Jun 13, 2026

Uh oh!

github-actions Bot commented Jun 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

pelikhan commented Jun 13, 2026

Uh oh!

github-actions Bot commented Jun 13, 2026

Uh oh!

Copilot AI commented Jun 13, 2026

Uh oh!

pelikhan commented Jun 13, 2026

Uh oh!

Copilot AI commented Jun 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Jun 13, 2026

Uh oh!

Copilot AI commented Jun 13, 2026

Uh oh!

github-actions Bot commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

pelikhan commented Jun 13, 2026

Uh oh!

github-actions Bot commented Jun 13, 2026

Uh oh!

Copilot AI commented Jun 13, 2026

Uh oh!

pelikhan commented Jun 13, 2026

Uh oh!

Copilot AI commented Jun 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jun 13, 2026 •

edited

Loading

github-actions Bot commented Jun 13, 2026 •

edited

Loading