refactor: rename guard/init.go, relocate expandTracingVariables, consolidate collaborator_permission helpers

[Copilot]

Three low-severity structural issues identified by semantic function clustering analysis: a misleadingly named file, a domain-specific function in a generic utility file, and a split response-building concern.

Changes

• internal/guard/init.go → internal/guard/label_agent.go: File contained only RunLabelAgent(...) — no init() logic. Logger var renamed logGuardInit → logLabelAgent to match.

• expandTracingVariables moved from config/expand.go → config/config_tracing.go: expand.go is now a pure generic expansion utility (expandVariablesCore, expandVariables, ExpandRawJSONVariables, expandEnvVariables). The tracing-domain wrapper belongs with TracingConfig and validateOpenTelemetryConfig.

• LogAndWrapCollaboratorPermission moved from mcp/collaborator_permission.go → mcp/tool_result.go: Co-locates it with BuildMCPTextResponse, which it calls directly. collaborator_permission.go is now a single-concern file containing only ParseCollaboratorPermissionArgs.

[Copilot]

Pull request overview

Refactors a few small structural/layout concerns to better align file names and helper locations with their actual responsibilities, and to reduce duplicated collaborator-permission response handling across server/proxy code paths.

Changes:

• Renamed the guard LabelAgent runner file to label_agent.go and updated its logger namespace/variable name accordingly.
• Moved expandTracingVariables from the generic expansion utility file into config_tracing.go alongside TracingConfig/OpenTelemetry validation.
• Relocated LogAndWrapCollaboratorPermission into tool_result.go next to BuildMCPTextResponse, leaving collaborator_permission.go focused on argument parsing.

Show a summary per file

File	Description
internal/mcp/tool_result.go	Adds LogAndWrapCollaboratorPermission alongside MCP response-building helpers.
internal/mcp/collaborator_permission.go	Removes the log/wrap helper, leaving only argument parsing.
internal/guard/label_agent.go	Renames logger variable/namespace to match the file’s LabelAgent responsibility.
internal/config/expand.go	Removes tracing-specific expansion wrapper to keep this file generic.
internal/config/config_tracing.go	Adds expandTracingVariables next to tracing config and validation logic.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 5/5 changed files
• Comments generated: 0