Skip to content

Align list_repository_collaborators DIFC integrity to reader-level #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
May 16, 2026
+4 −4
Merged

Align list_repository_collaborators DIFC integrity to reader-level #5843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9143e7
Initial plan
Copilot May 16, 2026
f0f232d
fix(guard): set collaborator listing to reader integrity
Copilot May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions guards/github-guard/rust-guard/src/labels/tool_rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,9 @@ pub fn apply_tool_labels(
// Lists users with access to the repository; reveals who holds write/admin rights.
// S = private policy scope — collaborator/permission information is access-controlled
// even for public repositories.
// I = writer (GitHub-controlled repository access metadata)
// I = reader (access-sensitive metadata should not directly authorize writes)
secrecy = policy_private_scope_label(&owner, &repo, repo_id, ctx);
integrity = writer_integrity(repo_id, ctx);
integrity = reader_integrity(repo_id, ctx);
}

// === Content Access ===
Expand Down Expand Up @@ -939,11 +939,11 @@ mod tests {
&ctx,
);
let _ = secrecy; // secrecy inherits from repo visibility (backend unavailable in tests)
let expected_integrity = super::writer_integrity("octocat/hello-world", &ctx);
let expected_integrity = super::reader_integrity("octocat/hello-world", &ctx);
assert_eq!(
integrity,
expected_integrity,
"list_repository_collaborators must produce writer-level integrity"
"list_repository_collaborators must produce reader-level integrity"
);
}
}
Loading