[test-improver] Improve tests for mcp/tool_result

[github-actions]

Test Improvements: tool_result_test.go

File Analyzed

• Test File: internal/mcp/tool_result_test.go
• Package: internal/mcp
• Implementation: internal/mcp/tool_result.go

Improvements Made

1. Increased Coverage

• ✅ Added test for audio content with missing data field
• ✅ Added test for image content with unsupported data type (e.g., int) — covers decodeContentData default: branch
• ✅ Added test for image content with nil data value
• ✅ Added test for resource content where json.Unmarshal into sdk.ResourceContents fails
• Previous Coverage: decodeContentData 85.7%, convertContentItem 96.4%
• New Coverage: decodeContentData 100%, convertContentItem 100%

2. Better Testing Patterns

• ✅ New tests use existing testify assertion patterns (assert.Error, assert.ErrorContains, assert.Nil) consistent with the file's style
• ✅ Descriptive subtest names explain the invariant being asserted
• ✅ Comments explain why each case is important (e.g., guarding against corrupted backend responses)

3. Cleaner & More Stable Tests

• ✅ Each subtest is independent with no shared state
• ✅ Tests use inline data, no external dependencies

Test Execution

All tests pass:

ok  	github.com/github/gh-aw-mcpg/internal/mcp	2.325s

Coverage improvement in tool_result.go:

tool_result.go:145: decodeContentData   85.7% → 100.0%
tool_result.go:98:  convertContentItem  96.4% → 100.0%

Why These Changes?

tool_result.go is central to MCP response handling — it converts every backend tool result into the SDK format. The uncovered branches represent real error conditions (unsupported data types, unmarshalable resources) that could surface from misbehaving backends. Adding these tests ensures the error paths are exercised and their error messages are validated.

---

Generated by Test Improver Workflow
Focuses on better patterns, increased coverage, and more stable tests

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• invalidhostthatdoesnotexist12345.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "invalidhostthatdoesnotexist12345.com"

See Network Configuration for more information.

Generated by Test Improver · ● 2.5M · ◷

[Copilot]

Pull request overview

Adds unit tests to internal/mcp/tool_result_test.go to cover previously-untested error branches in decodeContentData and convertContentItem, raising both to 100% coverage.

Changes:

• New subtests for missing audio data, unsupported data type (int), and nil data value in image content.
• New top-level test for resource JSON that fails to unmarshal into sdk.ResourceContents.

Show a summary per file

File	Description
internal/mcp/tool_result_test.go	Adds four tests exercising error paths of decodeContentData and the resource-unmarshal branch of convertContentItem.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0