smoke-copilot: add artifact readability test#5711
Merged
Merged
Conversation
Adds test step 6 that verifies all files under /tmp/gh-aw/mcp-logs/ are readable. This ensures permission issues (like the wazero-cache 0700 directory) cause an explicit smoke test failure instead of being silently swallowed by the framework's continue-on-error on artifact upload. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a readability check step to the smoke-copilot workflow so restrictive file permissions under /tmp/gh-aw/mcp-logs/ (e.g. the 0700 wazero-cache directory) surface as explicit test failures rather than being silently swallowed by the framework's continue-on-error artifact upload.
Changes:
- Adds step 6 "Artifact Readability Testing" that runs
find /tmp/gh-aw/mcp-logs/ -not -readableand fails the test if any output is produced.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-copilot.md | Adds new test step 6 to detect unreadable files/dirs in mcp-logs prior to artifact upload. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new test step to the smoke-copilot workflow that verifies all files under
/tmp/gh-aw/mcp-logs/are readable before the framework's artifact upload step runs.Problem
The wazero-cache directory was created with
0700permissions, causing the artifact upload step to fail with EACCES. However, because the framework usescontinue-on-error: trueon the upload step, this failure was silently swallowed — the smoke test still reported success.Fix
Test step 6 now runs
find /tmp/gh-aw/mcp-logs/ -not -readableand fails the overall test if any files/directories have restrictive permissions. This ensures future permission issues are surfaced as explicit test failures rather than silent artifact upload errors.