fix: skip playwright integration test on Docker network failures#5699
Merged
Conversation
When the Docker registry is unreachable (proxy timeout, connection refused), the test should skip gracefully instead of fatally failing, since the network issue is environmental rather than a code bug. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Playwright local Dockerfile integration test more resilient in environments where Docker is available but cannot pull the base image due to network connectivity failures.
Changes:
- Captures Docker build output as a string for reuse.
- Skips
TestPlaywrightWithLocalDockerfilewhen build output indicates Docker registry/network resolution failures.
Show a summary per file
| File | Description |
|---|---|
test/integration/playwright_test.go |
Adds network-failure detection around docker build so the integration test skips instead of failing fatally. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Docker can't pull the base image (e.g., registry timeout through a proxy),
TestPlaywrightWithLocalDockerfilenow skips gracefully instead of fatally failing.The test already skips when Docker isn't available — this extends that pattern to handle network connectivity issues during
docker build.