fix: update guard policy override test to match []string repos type#5661
Merged
Conversation
BuildAllowOnlyPolicy returns []string for owner+repo scoped policies, but the test asserted against a plain string. Update the assertion to match the actual type. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a failing config unit test to align with the current BuildAllowOnlyPolicy behavior where owner+repo scoped allow-only policies store repos as a []string (rather than a plain string). This keeps the guard policy override tests consistent with the guard policy construction logic.
Changes:
- Fixes
TestResolveGuardPolicyOverrideassertion to expect[]string{"myorg/myrepo"}for owner+repo scoped allow-only policies.
Show a summary per file
| File | Description |
|---|---|
| internal/config/guard_policy_override_test.go | Updates the scoped-repo assertion to match AllowOnly.Repos being a []string for owner/repo scopes. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TestResolveGuardPolicyOverride/cli_changed_with_owner_and_repo_builds_scoped_policyfails becauseBuildAllowOnlyPolicyreturns[]string{"myorg/myrepo"}for owner+repo scoped policies, but the test asserted against a plain string"myorg/myrepo".Fix
One-line fix: update the assertion to expect
[]string{"myorg/myrepo"}instead of"myorg/myrepo".Verification
make agent-finishedpasses — all checks green.