Remove unused export: CopilotModelValidationResult#5029
Conversation
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
There was a problem hiding this comment.
Pull request overview
This PR reduces the public TypeScript API surface by making CopilotModelValidationResult a module-private type alias in src/copilot-model.ts, while still using it internally as the return type of validateCopilotModel.
Changes:
- Remove the
exportmodifier fromCopilotModelValidationResultso it is no longer importable by external modules. - Keep
validateCopilotModel()’s return type unchanged within the module.
Show a summary per file
| File | Description |
|---|---|
src/copilot-model.ts |
Makes CopilotModelValidationResult non-exported to avoid exposing an unused type as part of the package’s public API. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
🔬 Smoke Test: Copilot PAT Auth — PASS
PR: "Remove unused export: CopilotModelValidationResult" Overall: PASS (verifiable tests passed; file test skipped due to unsubstituted template vars in workflow)
|
🔬 Smoke Test Results
PR: "Remove unused export: CopilotModelValidationResult" — Overall: PASS (MCP verified; pre-step data unavailable due to unsubstituted template variables)
|
|
Overall: PASS
|
|
Remove unused export: CopilotModelValidationResult Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
🧪 Chroot Version Comparison Results
Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environments.
|
Smoke Test Results
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
|
✅ Smoke Test: Copilot BYOK (Direct Mode) - PASS
Running in direct BYOK mode via
|
Smoke Test Results: FAIL ❌
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
|
CopilotModelValidationResultwas exported fromsrc/copilot-model.tsbut never imported anywhere else in the codebase, unnecessarily expanding the public API surface.Changes
src/copilot-model.ts: DropexportfromCopilotModelValidationResulttype alias — it remains usable within the module as the return type ofvalidateCopilotModel, just no longer part of the public contract.