Skip to content

Remove unused export: isContainerStartupFailureError#5023

Merged
lpcox merged 2 commits into
mainfrom
copilot/remove-unused-export-iscontainerstartupfailureerro
Jun 15, 2026
Merged

Remove unused export: isContainerStartupFailureError#5023
lpcox merged 2 commits into
mainfrom
copilot/remove-unused-export-iscontainerstartupfailureerro

Conversation

Copilot AI commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

isContainerStartupFailureError in src/container-startup-diagnostics.ts was exported but never imported anywhere else in the codebase, making it dead public API.

Change

  • src/container-startup-diagnostics.ts: Drop export from isContainerStartupFailureError, making it a module-internal helper. The function continues to be used within the same file.
// Before
export function isContainerStartupFailureError(errorMsg: string, containerName: string): boolean {

// After
function isContainerStartupFailureError(errorMsg: string, containerName: string): boolean {

Copilot AI changed the title [WIP] Remove unused export isContainerStartupFailureError Remove unused export: isContainerStartupFailureError Jun 15, 2026
Copilot finished work on behalf of lpcox June 15, 2026 13:44
Copilot AI requested a review from lpcox June 15, 2026 13:44
@lpcox lpcox marked this pull request as ready for review June 15, 2026 14:36
Copilot AI review requested due to automatic review settings June 15, 2026 14:36
@github-actions

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 96.86% 96.90% 📈 +0.04%
Statements 96.73% 96.77% 📈 +0.04%
Functions 98.81% 98.81% ➡️ +0.00%
Branches 91.24% 91.27% 📈 +0.03%
📁 Per-file Coverage Changes (2 files)
File Lines (Before → After) Statements (Before → After)
src/container-startup-diagnostics.ts 96.0% → 95.9% (-0.06%) 96.2% → 96.1% (-0.05%)
src/workdir-setup.ts 92.6% → 94.4% (+1.85%) 92.6% → 94.4% (+1.85%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the module’s public surface area by making isContainerStartupFailureError an internal helper in src/container-startup-diagnostics.ts, since it isn’t referenced anywhere outside that module.

Changes:

  • Removed the export modifier from isContainerStartupFailureError.
  • Kept the function in place and continued using it internally within the same file.
Show a summary per file
File Description
src/container-startup-diagnostics.ts Makes isContainerStartupFailureError module-private while preserving existing internal behavior.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions

Copy link
Copy Markdown
Contributor

🔬 Smoke Test: Copilot PAT — PASS

Test Result
GitHub MCP connectivity
GitHub.com HTTP connectivity
File write/read

Overall: PASS — Auth mode: PAT (COPILOT_GITHUB_TOKEN)

PR: "Remove unused export: isContainerStartupFailureError" by @Copilot · Assignees: @lpcox, @Copilot

🔑 PAT report filed by Smoke Copilot PAT

@github-actions

Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results — PASS

Test Result
GitHub MCP connectivity
GitHub.com HTTP ✅ 200
File write/read

PR: Remove unused export: isContainerStartupFailureError
Author: @Copilot | Assignees: @lpcox, @Copilot

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot

@github-actions

Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot BYOK (Direct Mode)

PASS — Running in direct BYOK mode via api-proxy → api.githubcopilot.com

Test Result
MCP Connectivity
GitHub.com HTTP
File I/O
BYOK Inference

@Copilot @lpcox

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test Results

Overall status: FAIL

Last 2 Merged PRs:

  1. Deduplicate Copilot bearer-prefix stripping in api-proxy
  2. refactor(api-proxy): deduplicate guard enforcement between HTTP and WebSocket paths, fix 3 missing WebSocket guards

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions

Copy link
Copy Markdown
Contributor

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3
Node.js v24.16.0 v22.22.3
Go go1.22.12 go1.22.12

Overall: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: GitHub Actions Services Connectivity

Check Result
Redis PING ❌ Timed out (no PONG)
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ Timed out

Overall: FAILhost.docker.internal is not reachable from this runner environment. Services on ports 6379 and 5432 did not respond.

🔌 Service connectivity validated by Smoke Services

@github-actions

Copy link
Copy Markdown
Contributor

Deduplicate Copilot bearer-prefix stripping in api-proxy — ✅
refactor(api-proxy): deduplicate guard enforcement between HTTP and WebSocket paths, fix 3 missing WebSocket guards — ✅
GitHub page title — ✅
Temp file write/read — ✅
npm ci && npm run build — ✅
Overall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak 1/1 passed ✅ PASS
Deno std 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note (Java): Maven local repo redirected to $HOME/m2-repo because the default ~/.m2/repository was owned by root in this runner environment. All tests still passed correctly.

Generated by Build Test Suite for issue #5023 ·

@lpcox lpcox merged commit 4871cd7 into main Jun 15, 2026
76 of 83 checks passed
@lpcox lpcox deleted the copilot/remove-unused-export-iscontainerstartupfailureerro branch June 15, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants