Remove unused export: isContainerStartupFailureError#5023
Conversation
isContainerStartupFailureError
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
Coverage comparison generated by |
There was a problem hiding this comment.
Pull request overview
This PR reduces the module’s public surface area by making isContainerStartupFailureError an internal helper in src/container-startup-diagnostics.ts, since it isn’t referenced anywhere outside that module.
Changes:
- Removed the
exportmodifier fromisContainerStartupFailureError. - Kept the function in place and continued using it internally within the same file.
Show a summary per file
| File | Description |
|---|---|
| src/container-startup-diagnostics.ts | Makes isContainerStartupFailureError module-private while preserving existing internal behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
🔬 Smoke Test: Copilot PAT — PASS
Overall: PASS — Auth mode: PAT (COPILOT_GITHUB_TOKEN) PR: "Remove unused export:
|
🔬 Smoke Test Results — PASS
PR: Remove unused export: Overall: PASS ✅
|
🔥 Smoke Test: Copilot BYOK (Direct Mode)✅ PASS — Running in direct BYOK mode via api-proxy → api.githubcopilot.com
|
Smoke Test Results
Overall status: FAIL Last 2 Merged PRs:
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Chroot Version Comparison Results
Overall: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot environments.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL —
|
|
Deduplicate Copilot bearer-prefix stripping in api-proxy — ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
isContainerStartupFailureErrorinsrc/container-startup-diagnostics.tswas exported but never imported anywhere else in the codebase, making it dead public API.Change
src/container-startup-diagnostics.ts: DropexportfromisContainerStartupFailureError, making it a module-internal helper. The function continues to be used within the same file.