Harden gh-aw installation in agentic workflow lock files#3260
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
This PR hardens how gh-aw is installed in GitHub Actions workflow lock files so downstream MCP/containerization steps always have an executable gh-aw binary available, aligning the affected workflows with the repo’s resilient install pattern.
Changes:
- Replaced the legacy
gh extension install/upgradeapproach with a binary-first discovery +install-gh-aw.shfallback in two lock workflows. - Ensured the binary is re-resolved post-install and only copied to
${RUNNER_TEMP}/gh-awif it’s executable. - Added a Jest regression test to prevent reintroducing the legacy install pattern in
.lock.ymlworkflows.
Show a summary per file
| File | Description |
|---|---|
scripts/ci/workflow-gh-aw-install.test.ts |
Adds a regression test to enforce resilient gh-aw installation patterns in lock workflows. |
.github/workflows/pelis-agent-factory-advisor.lock.yml |
Updates the gh-aw install step to use the fallback installer pattern and require an executable binary before copying. |
.github/workflows/ci-cd-gaps-assessment.lock.yml |
Same installer hardening as above to prevent pre-agent workflow failures due to missing gh-aw binary. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@copilot merge main |
Merged |
Smoke Test Results
Overall: 2/3 PASS — GitHub API authentication issue detected (HTTP 401 on gh CLI)
|
🔥 Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: PASS (MCP 401 is a sandbox constraint, not a BYOK failure)
|
🔬 Smoke Test Results
Overall: FAIL Template variables (
|
|
Smoke Test: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
Smoke test result: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL — Neither Redis nor PostgreSQL service containers were reachable from the runner.
|
The scheduled CI/CD Pipelines and Integration Tests Gap Assessment workflow was failing before agent execution because its
gh-awsetup step could leave no executable binary for downstream MCP/containerization steps. This aligns the affected lock files with the repository’s more resilient install pattern.Workflow fix
gh extension install/upgradeflow in:.github/workflows/ci-cd-gaps-assessment.lock.yml.github/workflows/pelis-agent-factory-advisor.lock.ymlgh-awbinary if presentinstall-gh-aw.shonly when needed${RUNNER_TEMP}/gh-awFailure mode addressed
gh extension list/gh extension installstate alone.gh-awbinary can actually be found.Regression coverage
scripts/ci/workflow-gh-aw-install.test.tsto guard lock workflows against reintroducing the legacy install pattern.