Skip to content

Actions: Add missing runs-on (managing complex workflows) #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2020
Merged

Actions: Add missing runs-on (managing complex workflows) #667

merged 2 commits into from
Nov 4, 2020

Conversation

Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Oct 19, 2020 •
edited
Loading

Also fix indentation in another example

Why:

The adjacent jobs have runs-on keys. The one job missing it caused confusion:
https://github.community/t/reusing-sharing-inheriting-steps-between-jobs-declarations/16851/19?u=simran-b

What's being changed:

Add runs-on: ubuntu-latest. Also fix indentation in another example.

Check off the following:

@Simran-B
Actions: Add missing runs-on (managing complex workflows)
0585f44 
Also fix indentation in another example
@janiceilene
Copy link
Contributor

Thanks @Simran-B! I'll get this triaged for review 🌟

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 20, 2020
@janiceilene janiceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020
@lucascosti lucascosti self-assigned this Nov 4, 2020
lucascosti
lucascosti approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, correct for both examples. Thanks again for these fixes, @Simran-B! 🚀

@lucascosti lucascosti merged commit eaa94cc into github:main Nov 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@Simran-B Simran-B deleted the patch-2 branch November 4, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascosti lucascosti lucascosti approved these changes

Assignees

@lucascosti lucascosti

Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simran-B @janiceilene @lucascosti