-
Notifications
You must be signed in to change notification settings - Fork 62.4k
docs(pull_request_webhook_properties): update ‘action’ description #5945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tion Signed-off-by: Jai Govindani <[email protected]>
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Signed-off-by: Jai Govindani <[email protected]>
Signed-off-by: Jai Govindani <[email protected]>
Not sure if the list delimiters (between the item and the description) should be hyphens or colons, seeing both on https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request_review https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#release |
Link to specific section in preview deployment: https://docs-5945--jaifix-2257.herokuapp.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request |
@jai Thank you so much for opening a PR to make this fix and giving such detailed information about your changes! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for opening this PR! I like your idea to turn the info into a bulleted list to make it more readable.
Our repo is currently frozen for a release tomorrow, but I will queue this to merge as soon as the freeze lifts.
Good catch! Given this discrepancy, either choice is good. As a long term fix, we should choose one and update the style guide/existing articles. (You are quite welcome to open an issue for this, but definitely not expected to!) |
I'll open an issue and propose an addition to the Style Guide, coming soon! |
@skedwards88 I proposed something here #6010. Hope the wording wasn't too meta/obscure, happy to make it more human-friendly. Writing docs on how to write docs is a bit meta after all 😂 |
opened #6009 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Signed-off-by: Jai Govindani [email protected]
Why:
Closes #2257
What's being changed:
Turned the description of the
pull_request
payload objectaction
into a list to prepare for adding a description to various terms likesynchronize
(as mentioned in #2257)Check off the following:
Writer impact (This section is for GitHub staff members only):