Skip to content

docs(pull_request_webhook_properties): update ‘action’ description #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2021

Conversation

jai
Copy link
Contributor

@jai jai commented May 2, 2021

Signed-off-by: Jai Govindani [email protected]

Why:

Closes #2257

What's being changed:

Turned the description of the pull_request payload object action into a list to prepare for adding a description to various terms like synchronize (as mentioned in #2257)

CleanShot 2021-05-02 at 12 07 02@2x

Check off the following:

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (eg. a "before and after video")

@welcome
Copy link

welcome bot commented May 2, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 2, 2021
@jai
Copy link
Contributor Author

jai commented May 2, 2021

Not sure if the list delimiters (between the item and the description) should be hyphens or colons, seeing both on

https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#pull_request_review
CleanShot 2021-05-02 at 12 24 21

https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#release
CleanShot 2021-05-02 at 12 24 45

@jai jai marked this pull request as ready for review May 2, 2021 05:25
@jai
Copy link
Contributor Author

jai commented May 2, 2021

@janiceilene
Copy link
Contributor

@jai Thank you so much for opening a PR to make this fix and giving such detailed information about your changes! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 3, 2021
@skedwards88 skedwards88 self-assigned this May 4, 2021
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for opening this PR! I like your idea to turn the info into a bulleted list to make it more readable.

Our repo is currently frozen for a release tomorrow, but I will queue this to merge as soon as the freeze lifts.

@skedwards88 skedwards88 removed their assignment May 4, 2021
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label May 4, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label May 4, 2021
@skedwards88
Copy link
Contributor

Not sure if the list delimiters (between the item and the description) should be hyphens or colons, seeing both

Good catch! Given this discrepancy, either choice is good. As a long term fix, we should choose one and update the style guide/existing articles. (You are quite welcome to open an issue for this, but definitely not expected to!)

@jai
Copy link
Contributor Author

jai commented May 4, 2021

I'll open an issue and propose an addition to the Style Guide, coming soon!

@jai
Copy link
Contributor Author

jai commented May 4, 2021

@skedwards88 I proposed something here #6010. Hope the wording wasn't too meta/obscure, happy to make it more human-friendly. Writing docs on how to write docs is a bit meta after all 😂

@jai
Copy link
Contributor Author

jai commented May 4, 2021

I'll open an issue and propose an addition to the Style Guide, coming soon!

opened #6009

@janiceilene janiceilene merged commit 06e167d into github:main May 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in definition of terms like "synchronize" for Github Action Activity types
3 participants