Skip to content

Registry URLs must include https:// #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Registry URLs must include https:// #584

merged 3 commits into from
Nov 4, 2020

Conversation

jcansdale
Copy link
Contributor

Why:

Registry URLs must include https://. Without this, publish will fail with the following warning/error:

npm WARN invalid config registry="npm.pkg.github.com"
npm WARN invalid config Must be a full url with 'http://'
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@jcansdale-test%2fnpm-errors - Not found
npm ERR! 404 

https://github.com/jcansdale-test/npm-errors/runs/1263431619?check_suite_focus=true#step:4:1

What's being changed:

Changing the highlighted line to include https://.

image

Check off the following:

@welcome
Copy link

welcome bot commented Oct 16, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks for opening a PR @jcansdale! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team labels Oct 19, 2020
@janiceilene janiceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020
Copy link
Contributor

@rachmari rachmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcansdale thank you for this update! This looks great. I'll get it merged right away. 🚢

@rachmari rachmari self-assigned this Nov 4, 2020
@madmax25361

This comment has been minimized.

@rachmari rachmari merged commit 8c64cae into main Nov 4, 2020
@rachmari rachmari deleted the registry-https branch November 4, 2020 18:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Co-authored-by: Lana Brindley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! packages This issue or pull request should be reviewed by the docs packages team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants