Skip to content

Specify that merge commit email address is only available when creating a merge commit #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2020
Merged

Specify that merge commit email address is only available when creating a merge commit #569

merged 4 commits into from
Nov 2, 2020

Conversation

greysteil
Copy link
Contributor

Why:

The option to select an email when merging a pull request is only available when creating a merge commit.

What's being changed:

The text in step 5 of this page.

Check off the following:

@welcome
Copy link

welcome bot commented Oct 15, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

mikesea
mikesea reviewed Oct 15, 2020
View reviewed changes
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 24, 2020
@greysteil greysteil requested a review from mikesea October 25, 2020 09:52
@janiceilene
Copy link
Contributor

👋 @greysteil Let me know when this is ready for a writer review!

mikesea
mikesea approved these changes Oct 28, 2020
View reviewed changes
Copy link

@mikesea mikesea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @greysteil! lgtm!

@greysteil
Copy link
Contributor Author

@janiceilene ready now! :octocat:

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Oct 28, 2020
@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 28, 2020
hubwriter
hubwriter approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greysteil - thanks for adding this.
This needed a tiny correction to the markdown, which I've gone ahead and committed.
Right now we're not merging to main on this repo, but I'll get this change merged in as soon as we start merging again.

@hubwriter hubwriter self-assigned this Oct 29, 2020
@janiceilene janiceilene merged commit bbfb168 into main Nov 2, 2020
@janiceilene janiceilene deleted the email-selection branch November 2, 2020 22:06
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni nschonni mentioned this pull request Nov 2, 2020
Closed
4 tasks
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Loquacity
Add operations section (github#569)
ee0878e 
* Add operations section

* Test forking procedure and add screenshot

* Add note about password
@Chantall1602 Chantall1602 mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesea mikesea mikesea approved these changes

@hubwriter hubwriter hubwriter approved these changes

Assignees

@hubwriter hubwriter

Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greysteil @janiceilene @mikesea @hubwriter