Update example with Octokit Checks API methods #3375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octokit supports creating and updating checks by using `create_check_run` and `update_check_run`: https://rdoc.info/gems/octokit/Octokit/Client/Checks
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
@matiasalbarello Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
janiceilene
added
content
|
It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening and triaging this for review 💛 |
github-actions
bot
removed
the
waiting for review
skedwards88
approved these changes
Apr 21, 2021
github-actions
bot
removed
the
waiting for review
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octokit supports creating and updating checks by using
create_check_runandupdate_check_run: https://rdoc.info/gems/octokit/Octokit/Client/ChecksWhy: the example is outdated and the cited gem now supports appropriated methods.
What's being changed: use
create_check_runandupdate_check_runof the used gem instead of post and patch to the API.Check off the following: