Skip to content

Update building-and-testing-net.md #32613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Update building-and-testing-net.md #32613

merged 2 commits into from
Jun 13, 2024

Conversation

mark-mxwl
Copy link
Contributor

Why:

Closes: #32098

What's being changed (if available, include any code snippets, screenshots, or gifs):

Revised the workflow example to include the updated syntax for setup-dotnet NuGet dependency caching (v3.2.0). As the action uses @toolkit/cache under the hood, there's no need to configure @actions/cache separately. The article has been revised to reflect changes made to the workflow example.

Note: I do wonder if it's necessary to include an installation step in the workflow, as dependency installation is covered the previous section. Thoughts?

Reference material:
Caching NuGet Packages
setup-dotnet v3.2.0

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 21, 2024
Copy link
Contributor

github-actions bot commented Apr 21, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/automating-builds-and-tests/building-and-testing-net.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

amin1419

This comment was marked as spam.

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 23, 2024
@nguyenalex836
Copy link
Contributor

@mark-mxwl Thanks so much for opening a PR! I'll get this triaged for review ✨

@EB039

This comment was marked as spam.

@na1307
Copy link

na1307 commented May 7, 2024

The changes do not mention NuGet lock files. That workflow doesn't work out of the box because generating a NuGet lock file requires modifying the project file.

Copy link
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mark-mxwl, thank you so much for updating this example! 💛

Note: I do wonder if it's necessary to include an installation step in the workflow, as dependency installation is covered the previous section. Thoughts?

I do like having that extra context in the example to show what a more complete workflow would look like, so I'm inclined to leave the installation step. Also, I think since it only takes up two lines, it's not too much mental overhead for readers. 👍

Thank you again for making these updates, I'm going to get this merged!

@SiaraMist SiaraMist added this pull request to the merge queue Jun 13, 2024
Merged via the queue into github:main with commit 1403ad3 Jun 13, 2024
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Info on caching in .NET is outdated
6 participants