-
Notifications
You must be signed in to change notification settings - Fork 62.4k
Update building-and-testing-net.md #32613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@mark-mxwl Thanks so much for opening a PR! I'll get this triaged for review ✨ |
This comment was marked as spam.
This comment was marked as spam.
The changes do not mention NuGet lock files. That workflow doesn't work out of the box because generating a NuGet lock file requires modifying the project file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mark-mxwl, thank you so much for updating this example! 💛
Note: I do wonder if it's necessary to include an installation step in the workflow, as dependency installation is covered the previous section. Thoughts?
I do like having that extra context in the example to show what a more complete workflow would look like, so I'm inclined to leave the installation step. Also, I think since it only takes up two lines, it's not too much mental overhead for readers. 👍
Thank you again for making these updates, I'm going to get this merged!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #32098
What's being changed (if available, include any code snippets, screenshots, or gifs):
Revised the workflow example to include the updated syntax for
setup-dotnet
NuGet dependency caching (v3.2.0). As the action uses @toolkit/cache under the hood, there's no need to configure @actions/cache separately. The article has been revised to reflect changes made to the workflow example.Note: I do wonder if it's necessary to include an installation step in the workflow, as dependency installation is covered the previous section. Thoughts?
Reference material:
Caching NuGet Packages
setup-dotnet v3.2.0
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.