Skip to content

remove hyphen in label to match UI #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2021
Merged

remove hyphen in label to match UI #3216

merged 4 commits into from
Feb 1, 2021

Conversation

317brian
Copy link
Contributor

@317brian 317brian commented Jan 26, 2021

Why:

The docs don't match the UI for this feature. The UI doesn't use - for the label Require branches to be up to date... (#3215)

What's being changed:

Removes the - in the references to the UI label

Check off the following:

@welcome
Copy link

welcome bot commented Jan 26, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@@ -86,8 +86,8 @@ You can set up required status checks to either be "loose" or "strict." The type

Copy link
Contributor

@janiceilene janiceilene Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening an issue and PR for this fix @brian-armory! I can't comment on the line above ☝️ but there's one more "up-to-date" on line 85. Could you update that one, as well, please? Let me know when you do and we'll get this merged in ⚡

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@janiceilene janiceilene self-assigned this Jan 28, 2021
@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Jan 28, 2021
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating that last one! This looks great 🥳 I'll update the branch and merge once tests are passing 🍏

@janiceilene janiceilene merged commit a3f5992 into github:main Feb 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI and docs don't match for "Required to be up to date" check
2 participants