-
Notifications
You must be signed in to change notification settings - Fork 62.5k
remove hyphen in label to match UI #3216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
addresses #3215
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@@ -86,8 +86,8 @@ You can set up required status checks to either be "loose" or "strict." The type | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for opening an issue and PR for this fix @brian-armory! I can't comment on the line above ☝️ but there's one more "up-to-date" on line 85. Could you update that one, as well, please? Let me know when you do and we'll get this merged in ⚡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating that last one! This looks great 🥳 I'll update the branch and merge once tests are passing 🍏
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
The docs don't match the UI for this feature. The UI doesn't use - for the label Require branches to be up to date... (#3215)
What's being changed:
Removes the
-
in the references to the UI labelCheck off the following: