Skip to content

Switch HTTP to HTTPS #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Switch HTTP to HTTPS #2941

merged 4 commits into from
Jan 21, 2021

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Jan 16, 2021

Why:

  • HTTPS protocol is more secure
  • HTTP redirects to HTTPS anyway

See Heroku deploy preview here: https://docs-2941--patch-1.herokuapp.com/en/github/authenticating-to-github/removing-sensitive-data-from-a-repository#purging-a-file-from-your-repositorys-history

What's being changed:

Check off the following:

@welcome
Copy link

welcome bot commented Jan 16, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@karlhorky Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Jan 19, 2021
@shati-patel shati-patel self-assigned this Jan 21, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @karlhorky! Your change looks good.

Thanks also for including a link to the Heroku deployment in your PR description—that's always helpful 😃

@shati-patel shati-patel merged commit 8900cd8 into github:main Jan 21, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@karlhorky
Copy link
Contributor Author

Great, glad to help @shati-patel ! Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants