Skip to content

Update building-and-testing-net.md #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Conversation

patrickhuber
Copy link
Contributor

@patrickhuber patrickhuber commented Jan 16, 2021

Why:

Missing a '$'. Build will fail with The workflow is not valid. .github/workflows/pipeline.yml (Line: 16, Col: 25): A mapping was not expected

What's being changed:

single character missing in sample

Check off the following:

Missing a '$'. Build will fail with `The workflow is not valid. .github/workflows/pipeline.yml (Line: 16, Col: 25): A mapping was not expected`
@welcome
Copy link

welcome bot commented Jan 16, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@patrickhuber Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Jan 19, 2021
@shati-patel shati-patel self-assigned this Jan 21, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this bug @patrickhuber! Much appreciated 😃

I'll get this merged shortly.

@shati-patel shati-patel merged commit 59500e6 into github:main Jan 21, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@patrickhuber patrickhuber deleted the patch-1 branch January 21, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants