Skip to content

Change usage of "container" to "container registry" #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jcansdale
Copy link
Contributor

Why:

Users are potentially confused by references to "container support". For example:

Ok, I'll check it out. I didn't do it because GitHub Container Registry is a term which lead me to think is for storing containers instead of images.

https://github.zendesk.com/agent/tickets/980826

What's being changed:

  • Change "Container guides for GitHub Packages" to "Guides for GitHub Container Registry"

Check off the following:

@jcansdale jcansdale changed the title Update container-guides-for-github-packages.md Change usage of "container" to "container registry" Jan 13, 2021
@janiceilene
Copy link
Contributor

@jcansdale Thanks for opening a PR! I see this is still in draft mode. Feel free to ping me when you're ready for a writer review and I'll get this triaged ⚡

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions bot closed this Feb 13, 2021
@janiceilene
Copy link
Contributor

It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening 💛

@janiceilene janiceilene reopened this Feb 16, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@jeremyepling
Copy link

We should close this PR or adapt it to use the updated naming scheme - https://docs.google.com/document/d/1BhHuQ7PhPf_ZTOjk2LYi4c-xUBrr9RUowmgkVeU_rXA/edit#

@jcansdale
Copy link
Contributor Author

@jeremyepling 👋🏻 I like @clarkbw's Container registry guide suggestion here:
https://github.slack.com/archives/CM82WM3LY/p1614117030013700?thread_ts=1614075029.012500&cid=CM82WM3LY

I'm going to close this PR and defer to the updated naming scheme. 😄

@jcansdale jcansdale closed this Mar 26, 2021
@Realest1Re Realest1Re mentioned this pull request Nov 20, 2021
@heiskr heiskr deleted the guides-for-ghcr branch September 21, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants