Update actions-billing.md #2137

hwine · 2020-12-15T20:54:07Z

Without "both", I interpreted text as referring to just one category: "public repositories using self-hosted runners", which is not correct.

You could also use an Oxford comma here :) but I think "both" is clearer.

Why:

#2134 details the perceived ambiguity.

What's being changed:

Add a word.

Check off the following:

All of the tests are passing.
I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
For content changes, I have reviewed the localization checklist
For content changes, I have reviewed the Content style guide for GitHub Docs.

Without "both", I interpreted text as referring to just one category: "public repositories using self-hosted runners", which is not correct. You could also use an Oxford comma here :) but I think "both" is clearer.

welcome · 2020-12-15T20:54:09Z

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

janiceilene · 2020-12-15T23:25:41Z

@hwine Thanks so much for opening a PR! I'll get this triaged for review ⚡

github-actions · 2020-12-23T17:27:06Z

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

janiceilene · 2020-12-23T19:01:50Z

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

github-actions · 2021-01-02T17:34:59Z

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

hwine · 2021-01-04T15:36:00Z

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

That's the flip side of community involvement :) Lots of extra admin time! (hoping this resets stale)

github-actions · 2021-01-11T17:52:18Z

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

hwine · 2021-01-11T17:58:37Z

stale reset

lucascosti · 2021-01-18T04:36:27Z

data/reusables/github-actions/actions-billing.md

@@ -1 +1 @@
-{% data variables.product.prodname_actions %} usage is free for public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits.
+{% data variables.product.prodname_actions %} usage is free for both public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits.


👋 Hi, @hwine! Thanks a lot for this suggestion; I agree that this could be misunderstood.

I think we could probably clear this up a little more, because IIUC, self-hosted runner usage is free for private repositories, but only for minutes. Storage is still counted for any uploaded workflow artifacts from self-hosted runners. The current wording might incorrectly imply that if you use self-hosted runners in a private repository, any uploaded storage usage is also free.

Suggested change

{% data variables.product.prodname_actions %} usage is free for both public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits.

{% data variables.product.prodname_actions %} usage is free for public repositories. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Self-hosted runner usage is free, and is not counted as billable minutes. Any usage beyond the included amounts is controlled by spending limits.

@chrispat Could you please confirm the wording ☝️ is ok?

One comment - I sure wouldn't know how to work it in smoothly - actions are not available for private repos on legacy plans. (I oversee a couple of those kind of orgs.)

That wording is correct.

One comment - I sure wouldn't know how to work it in smoothly - actions are not available for private repos on legacy plans. (I oversee a couple of those kind of orgs.)

@hwine Thanks, but this is already mentioned in the purple product callout that is at the top of most docs pages for Actions 🙂 , e.g.

oh, duh. I have to remember to read the top matter even when I enter via a deep link.

lucascosti

I think this is ready to merge! 🎉

github-actions · 2021-01-20T03:26:47Z

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Update actions-billing.md

1abfc51

Without "both", I interpreted text as referring to just one category: "public repositories using self-hosted runners", which is not correct. You could also use an Oxford comma here :) but I think "both" is clearer.

janiceilene linked an issue Dec 15, 2020 that may be closed by this pull request

Description of when GitHub Actions are free is confusing. #2134

Closed

janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 15, 2020

github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 23, 2020

janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 23, 2020

github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 2, 2021

github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 4, 2021

github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 11, 2021

janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 11, 2021

lucascosti reviewed Jan 18, 2021

View reviewed changes

lucascosti self-assigned this Jan 18, 2021

Merge branch 'main' into hwine-patch-1

a3c6710

lucascosti approved these changes Jan 20, 2021

View reviewed changes

lucascosti merged commit acc669a into github:main Jan 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update actions-billing.md #2137

Update actions-billing.md #2137

Uh oh!

hwine commented Dec 15, 2020 •

edited

Loading

Uh oh!

welcome bot commented Dec 15, 2020

Uh oh!

janiceilene commented Dec 15, 2020

Uh oh!

github-actions bot commented Dec 23, 2020

Uh oh!

janiceilene commented Dec 23, 2020

Uh oh!

github-actions bot commented Jan 2, 2021

Uh oh!

hwine commented Jan 4, 2021

Uh oh!

github-actions bot commented Jan 11, 2021

Uh oh!

hwine commented Jan 11, 2021

Uh oh!

lucascosti Jan 18, 2021

Uh oh!

hwine Jan 19, 2021

Uh oh!

chrispat Jan 19, 2021

Uh oh!

lucascosti Jan 20, 2021

Uh oh!

hwine Jan 20, 2021

Uh oh!

lucascosti left a comment

Uh oh!

github-actions bot commented Jan 20, 2021

Uh oh!

Uh oh!

		@@ -1 +1 @@
		{% data variables.product.prodname_actions %} usage is free for public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits.
		{% data variables.product.prodname_actions %} usage is free for both public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits.

Update actions-billing.md #2137

Update actions-billing.md #2137

Uh oh!

Conversation

hwine commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why:

What's being changed:

Check off the following:

Uh oh!

welcome bot commented Dec 15, 2020

Uh oh!

janiceilene commented Dec 15, 2020

Uh oh!

github-actions bot commented Dec 23, 2020

Uh oh!

janiceilene commented Dec 23, 2020

Uh oh!

github-actions bot commented Jan 2, 2021

Uh oh!

hwine commented Jan 4, 2021

Uh oh!

github-actions bot commented Jan 11, 2021

Uh oh!

hwine commented Jan 11, 2021

Uh oh!

lucascosti Jan 18, 2021

Choose a reason for hiding this comment

Uh oh!

hwine Jan 19, 2021

Choose a reason for hiding this comment

Uh oh!

chrispat Jan 19, 2021

Choose a reason for hiding this comment

Uh oh!

lucascosti Jan 20, 2021

Choose a reason for hiding this comment

Uh oh!

hwine Jan 20, 2021

Choose a reason for hiding this comment

Uh oh!

lucascosti left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 20, 2021

Uh oh!

Uh oh!

hwine commented Dec 15, 2020 •

edited

Loading