-
Notifications
You must be signed in to change notification settings - Fork 62.5k
Update actions-billing.md #2137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Without "both", I interpreted text as referring to just one category: "public repositories using self-hosted runners", which is not correct. You could also use an Oxford comma here :) but I think "both" is clearer.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@hwine Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨ |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
That's the flip side of community involvement :) Lots of extra admin time! (hoping this resets stale) |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
stale reset |
@@ -1 +1 @@ | |||
{% data variables.product.prodname_actions %} usage is free for public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits. | |||
{% data variables.product.prodname_actions %} usage is free for both public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi, @hwine! Thanks a lot for this suggestion; I agree that this could be misunderstood.
I think we could probably clear this up a little more, because IIUC, self-hosted runner usage is free for private repositories, but only for minutes. Storage is still counted for any uploaded workflow artifacts from self-hosted runners. The current wording might incorrectly imply that if you use self-hosted runners in a private repository, any uploaded storage usage is also free.
{% data variables.product.prodname_actions %} usage is free for both public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits. | |
{% data variables.product.prodname_actions %} usage is free for public repositories. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Self-hosted runner usage is free, and is not counted as billable minutes. Any usage beyond the included amounts is controlled by spending limits. |
@chrispat Could you please confirm the wording ☝️ is ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment - I sure wouldn't know how to work it in smoothly - actions are not available for private repos on legacy plans. (I oversee a couple of those kind of orgs.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That wording is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment - I sure wouldn't know how to work it in smoothly - actions are not available for private repos on legacy plans. (I oversee a couple of those kind of orgs.)
@hwine Thanks, but this is already mentioned in the purple product callout that is at the top of most docs pages for Actions 🙂 , e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, duh. I have to remember to read the top matter even when I enter via a deep link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge! 🎉
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Without "both", I interpreted text as referring to just one category: "public repositories using self-hosted runners", which is not correct.
You could also use an Oxford comma here :) but I think "both" is clearer.
Why:
#2134 details the perceived ambiguity.
What's being changed:
Add a word.
Check off the following: