Skip to content

Update actions-billing.md #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Update actions-billing.md #2137

merged 2 commits into from
Jan 20, 2021

Conversation

hwine
Copy link
Contributor

@hwine hwine commented Dec 15, 2020

Without "both", I interpreted text as referring to just one category: "public repositories using self-hosted runners", which is not correct.

You could also use an Oxford comma here :) but I think "both" is clearer.

Why:

#2134 details the perceived ambiguity.

What's being changed:

Add a word.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

Without "both", I interpreted text as referring to just one category: "public repositories using self-hosted runners", which is not correct.

You could also use an Oxford comma here :) but I think "both" is clearer.
@welcome
Copy link

welcome bot commented Dec 15, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@hwine Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene linked an issue Dec 15, 2020 that may be closed by this pull request
@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 15, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 23, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 23, 2020
@janiceilene
Copy link
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 2, 2021
@hwine
Copy link
Contributor Author

hwine commented Jan 4, 2021

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

That's the flip side of community involvement :) Lots of extra admin time! (hoping this resets stale)

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 4, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 11, 2021
@hwine
Copy link
Contributor Author

hwine commented Jan 11, 2021

stale reset

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 11, 2021
@@ -1 +1 @@
{% data variables.product.prodname_actions %} usage is free for public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits.
{% data variables.product.prodname_actions %} usage is free for both public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi, @hwine! Thanks a lot for this suggestion; I agree that this could be misunderstood.

I think we could probably clear this up a little more, because IIUC, self-hosted runner usage is free for private repositories, but only for minutes. Storage is still counted for any uploaded workflow artifacts from self-hosted runners. The current wording might incorrectly imply that if you use self-hosted runners in a private repository, any uploaded storage usage is also free.

Suggested change
{% data variables.product.prodname_actions %} usage is free for both public repositories and self-hosted runners. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Any usage beyond the included amounts is controlled by spending limits.
{% data variables.product.prodname_actions %} usage is free for public repositories. For private repositories, each {% data variables.product.prodname_dotcom %} account receives a certain amount of free minutes and storage, depending on the product used with the account. Self-hosted runner usage is free, and is not counted as billable minutes. Any usage beyond the included amounts is controlled by spending limits.

@chrispat Could you please confirm the wording ☝️ is ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment - I sure wouldn't know how to work it in smoothly - actions are not available for private repos on legacy plans. (I oversee a couple of those kind of orgs.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wording is correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment - I sure wouldn't know how to work it in smoothly - actions are not available for private repos on legacy plans. (I oversee a couple of those kind of orgs.)

@hwine Thanks, but this is already mentioned in the purple product callout that is at the top of most docs pages for Actions 🙂 , e.g.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, duh. I have to remember to read the top matter even when I enter via a deep link.

@lucascosti lucascosti self-assigned this Jan 18, 2021
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge! 🎉

@lucascosti lucascosti merged commit acc669a into github:main Jan 20, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description of when GitHub Actions are free is confusing.
4 participants