-
Notifications
You must be signed in to change notification settings - Fork 62.5k
Fixing non-working codesnippet. #18905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alert() does not exist in node.js. We can use console.log() instead.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@Jontes-Tech Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
Did I do anything wrong? Some checks failed... |
We have temporarily frozen our repo. 🧊 The failed checks should pass once we lift the freeze. Your PR is on the board for review, so no additional action on your side is needed at this moment. Thanks for checking in on this! 💛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! We'll get this merged down for you.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Thank you guys so much for merging. |
alert() does not exist in node.js. We can use console.log() instead.
Why:
The codeblock shows a command not usable by default in Node.JS, only usable in the browser, yet the article is in a Node.JS context.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Changing the command.
Check off the following: