Skip to content

Curious omission of English in supported languages #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Curious omission of English in supported languages #1863

merged 2 commits into from
Jan 7, 2021

Conversation

greglow-sdu
Copy link
Contributor

@greglow-sdu greglow-sdu commented Dec 7, 2020

Why:

There is a list of languages shown. It's not complete.

What's being changed:

I added English to the list of languages. English is supported.

Check off the following:

  • All of the tests are passing. N/A
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment) N/A
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Dec 7, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@greglow-sdu Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@janiceilene
Copy link
Contributor

Thanks @greglow-sdu (and @charlesrutabanzibwa 😸 )! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 7, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 15, 2020
@janiceilene
Copy link
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 16, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 23, 2020
@github-actions github-actions bot closed this Jan 2, 2021
@janiceilene
Copy link
Contributor

This was closed by stalebot over the holiday break, but it shouldn't have been! Re opening 💛

@janiceilene janiceilene reopened this Jan 4, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 4, 2021
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greglow-sdu - Apologies for the delay getting this reviewed over the holiday period.

Excellent spot. Thank you very much for fixing this. 👍

@hubwriter hubwriter self-assigned this Jan 7, 2021
@hubwriter
Copy link
Contributor

Merging now 🚢

@hubwriter hubwriter merged commit 126c9d6 into github:main Jan 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants