Skip to content

fix dropdown on mobile #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2020
Merged

fix dropdown on mobile #1732

merged 2 commits into from
Dec 3, 2020

Conversation

Arhell
Copy link
Contributor

@Arhell Arhell commented Dec 1, 2020

Why:

fix issue #1722

What's being changed:

Content won't jump
1

@Arhell Arhell marked this pull request as ready for review December 2, 2020 22:52
@Arhell
Copy link
Contributor Author

Arhell commented Dec 2, 2020

cc @chiedo

@chiedo
Copy link
Contributor

chiedo commented Dec 3, 2020

@Arhell can you explain the issue you're describing one more time? I'm not sure I understand. Also can you include before and after screenshots (maybe animated gifs if that will help)? Thanks!

@Arhell
Copy link
Contributor Author

Arhell commented Dec 3, 2020

@chiedo
Of course, when on mobile you click the dropdown then the content jumps
normal state
1
Before
2
content jumped down
after fix
3
the content is in place and the dropdown works correctly as it does in large resolutions without interfering with the content

@chiedo
Copy link
Contributor

chiedo commented Dec 3, 2020

Thank you! That makes perfect sense. Thanks for the fix!

@chiedo chiedo merged commit d62a724 into github:main Dec 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants