Skip to content

Properly capitalize "macOS" #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Properly capitalize "macOS" #1154

merged 2 commits into from
Dec 2, 2020

Conversation

stephenwade
Copy link
Contributor

@stephenwade stephenwade commented Nov 7, 2020

Why:

The name of Apple's desktop operating system should always be capitalized with a lowercase "m", like this:

macOS

Issue #1155

What's being changed:

Change all occurrences of "MacOS" to "macOS".

Check off the following:

@stephenwade stephenwade requested review from a team as code owners November 7, 2020 04:29
@welcome
Copy link

welcome bot commented Nov 7, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@heiskr heiskr removed the request for review from a team November 9, 2020 16:56
@janiceilene
Copy link
Contributor

Thanks so much for opening an issue and PR @stephenwade! I'll get this triaged for review 🎉

@janiceilene janiceilene added the content This issue or pull request belongs to the Docs Content team label Nov 9, 2020
@stephenwade
Copy link
Contributor Author

@janiceilene Just recreated this to remove any edits to the translations folder. I understand that content in this folder can't be changed with a PR.

@janiceilene janiceilene linked an issue Nov 17, 2020 that may be closed by this pull request
@janiceilene
Copy link
Contributor

Thanks so much @stephenwade!

dennagus referenced this pull request Nov 17, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 25, 2020
@stephenwade
Copy link
Contributor Author

not stale. cc: @janiceilene

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 26, 2020
@janiceilene
Copy link
Contributor

@stephenwade You're right, it's not stale! Thanks for your patience 💛 Our small team is working our way through reviewing all of the amazing contributions ✨

@shati-patel shati-patel self-assigned this Dec 2, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @stephenwade! You're absolutely right about the capitalization 😄

Apologies for the initial delay, but we'll get this merged shortly!

@shati-patel shati-patel merged commit 1d5f905 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"macOS" should always be properly capitalized
3 participants