Skip to content

Fix 'Allow select actions' wording and description #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

lucascosti
Copy link
Contributor

@lucascosti lucascosti commented Nov 6, 2020

Replaces PR: #941, and done in collaboration with @Simran-B

Why:

  • The description for Allow select actions does not mention that local actions are also allowed when using that setting.
  • The docs incorrectly name the setting Allow specific actions, when the label in the UI is Allow select actions.

What's being changed:

Adds some wording to the description stating that local actions are also allowed, and fixes the label text.

Stage previews:

Check off the following:

@lucascosti
Copy link
Contributor Author

Thanks for the original content for this, @Simran-B! Because I'm the creator of this PR, we have to wait until someone else on the docs team reviews and approves it 🙂

@Simran-B
Copy link
Contributor

Simran-B commented Nov 6, 2020

joshmgross said that

Local actions also includes any within an enterprise account.

It still doesn't say so here:

When you enable local actions only, workflows can only run actions located in your repository or organization.

https://docs-1112--lucascostiallow-spe.herokuapp.com/en/[email protected]/github/administering-a-repository/disabling-or-limiting-github-actions-for-a-repository#about-github-actions-permissions-for-your-repository

Copy link
Contributor

@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we improve the description of "local actions" in this PR too?

Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lucascosti
Copy link
Contributor Author

It still doesn't say so here:

Should we improve the description of "local actions" in this PR too?

Ah, yes! Thanks for calling that out. Done in 271c99a 🚀

I'll get this merged 🚢

@lucascosti lucascosti merged commit efe3b3b into main Nov 9, 2020
@lucascosti lucascosti deleted the lucascosti/allow-specific-actions branch November 9, 2020 02:00
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Add How To template

* typo

* Make Vale happy

* Rename file + line breaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants