Skip to content

Type inference: Rename some variables #20234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Aug 15, 2025

Rename variables to be consistent with the naming used in conditionSatisfiesConstraint.

@hvitved hvitved added the no-change-note-required This PR does not need a change note label Aug 15, 2025
@hvitved hvitved marked this pull request as ready for review August 15, 2025 12:11
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 12:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames variables in TypeInference.qll to improve consistency with naming conventions used in the conditionSatisfiesConstraint function. The changes ensure that variable names clearly distinguish between conditions and constraints throughout the type inference logic.

  • Renames variables to use condition/constraint naming pattern consistently
  • Updates parameter order in potentialInstantiationOf to align with consistent naming
  • Improves code readability by using more descriptive variable names

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hvitved hvitved merged commit 0144c77 into github:main Aug 21, 2025
39 checks passed
@hvitved hvitved deleted the type-inference/rename-vars branch August 21, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants