Split debug artifacts PR check into two jobs #1160
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,83 @@ | ||||||
| # Checks logs, SARIF, and database bundle debug artifacts exist. | ||||||
| name: PR Check - Debug artifact upload | ||||||
| env: | ||||||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||||||
| on: | ||||||
| push: | ||||||
| branches: | ||||||
| - main | ||||||
| - releases/v1 | ||||||
| - releases/v2 | ||||||
| pull_request: | ||||||
| types: | ||||||
| - opened | ||||||
| - synchronize | ||||||
| - reopened | ||||||
| - ready_for_review | ||||||
| workflow_dispatch: {} | ||||||
| jobs: | ||||||
| upload-artifacts: | ||||||
| strategy: | ||||||
| matrix: | ||||||
| os: [ubuntu-latest, macos-latest] | ||||||
| version: [stable-20210308, stable-20210319, stable-20210809, cached, latest, nightly-latest] | ||||||
| name: Upload debug artifacts | ||||||
| timeout-minutes: 45 | ||||||
| runs-on: ${{ matrix.os }} | ||||||
| steps: | ||||||
| - name: Check out repository | ||||||
| uses: actions/checkout@v3 | ||||||
| - name: Prepare test | ||||||
| id: prepare-test | ||||||
| uses: ./.github/prepare-test | ||||||
| with: | ||||||
| version: ${{ matrix.version }} | ||||||
| - uses: ./../action/init | ||||||
| with: | ||||||
| tools: ${{ steps.prepare-test.outputs.tools-url }} | ||||||
| debug: true | ||||||
| debug-artifact-name: my-debug-artifacts | ||||||
| debug-database-name: my-db | ||||||
| - name: Build code | ||||||
| shell: bash | ||||||
| run: ./build.sh | ||||||
| - uses: ./../action/analyze | ||||||
| id: analysis | ||||||
| download-and-check-artifacts: | ||||||
| name: Download and check debug artifacts | ||||||
| needs: upload-artifacts | ||||||
| timeout-minutes: 45 | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Download all artifacts | ||||||
| uses: actions/download-artifact@v3 | ||||||
| - name: Check expected artifacts exist | ||||||
| shell: bash | ||||||
| run: | | ||||||
| OPERATING_SYSTEMS="ubuntu-latest macos-latest" | ||||||
| VERSIONS="stable-20210308 stable-20210319 stable-20210809 cached latest nightly-latest" | ||||||
| LANGUAGES="cpp csharp go java javascript python" | ||||||
| for os in $OPERATING_SYSTEMS; do | ||||||
| for version in $VERSIONS; do | ||||||
| cd ./my-debug-artifacts-$os-$version | ||||||
|
||||||
| cd ./my-debug-artifacts-$os-$version | |
| cd "./my-debug-artifacts-$os-$version" |
There was a problem hiding this comment.
Ah interesting.. I wonder if it fails if it will continue onto the next directory? Probably not..
There was a problem hiding this comment.
It will not. This is because by default Actions runs bash steps with set -e (set -eo pipefail specifically; see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell), so any shell command exiting non-zero will fail the entire step.
You can turn this off in a given step by adding set +e at the beginning, but we don't need that here.
There was a problem hiding this comment.
Interesting! Thanks!
Uh oh!
There was an error while loading. Please reload this page.