Skip to content

Fix tags not being resolved before use. #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix tags not being resolved before use. #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions internal/pull/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,21 +144,26 @@ func (pullService *pullService) findRelevantReleases() ([]string, error) {
err = references.ForEach(func(reference *plumbing.Reference) error {
if relevantReferences.MatchString(reference.Name().String()) {
log.Debugf("Found %s.", reference.Name().String())
commit, err := localRepository.CommitObject(reference.Hash())
resolvedReference, err := localRepository.ResolveRevision(plumbing.Revision(reference.Name()))
if err != nil {
return errors.Wrapf(err, "Error loading commit %s for reference %s.", reference.Hash(), reference.Name().String())
return errors.Wrap(err, "Error resolving revision.")
}
log.Debugf("Resolved to %s.", resolvedReference.String())
commit, err := localRepository.CommitObject(*resolvedReference)
if err != nil {
return errors.Wrapf(err, "Error loading commit %s for reference %s.", resolvedReference.String(), reference.Name().String())
}
file, err := commit.File(defaultConfigurationPath)
if err != nil {
if err == object.ErrFileNotFound {
log.Debugf("Ignoring reference %s as it does not have a default configuration.", reference.Name().String())
return nil
}
return errors.Wrapf(err, "Error loading default configuration file from commit %s for reference %s.", reference.Hash(), reference.Name().String())
return errors.Wrapf(err, "Error loading default configuration file from commit %s for reference %s.", resolvedReference.String(), reference.Name().String())
}
content, err := file.Contents()
if err != nil {
return errors.Wrapf(err, "Error reading default configuration file content from commit %s for reference %s.", reference.Hash(), reference.Name().String())
return errors.Wrapf(err, "Error reading default configuration file content from commit %s for reference %s.", resolvedReference.String(), reference.Name().String())
}
configuration, err := actionconfiguration.Parse(content)
if err != nil {
Expand Down