[Feature] Add a copy Gerrit change link button #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will probably be in merge conflict with my other pull request #74 |
lekhmanrus
approved these changes
Sep 22, 2023
| form._NO_TRANSLATE_TargetLabel.Click += (s, e) => OsShellUtil.OpenUrlInDefaultBrowser(change); | ||
| public static void ShowSubmitted(IWin32Window owner, string changeUri) | ||
| { | ||
| if(owner == null || string.IsNullOrEmpty(changeUri)) |
There was a problem hiding this comment.
formatting (space)
Suggested change
| if(owner == null || string.IsNullOrEmpty(changeUri)) | |
| if (owner == null || string.IsNullOrEmpty(changeUri)) |
lekhmanrus
approved these changes
Sep 22, 2023
|
Hello, me again! 😇 Any chance to have a release of the plugin with my two merged pull requests when you will have some time ? Thanks again for your work! |
|
Hi @poupounetjoyeux, |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Since this is full UI feature, it's difficult to add unitary test
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In most case I want to send the gerrit change link to reviewers over my favourite communication tools and currently I need to click on the link to open it in my browser, then copy the URI to finally send it to reviewers
Issue Number: N/A
What is the new behavior?
We have a new 'Copy to clipboard' button that allows us to directly copy the gerrit change link to the clipboard and then paste it where we want without need to open the browser :
Does this PR introduce a breaking change?