Skip to content

Conversation

mikemeerschaert
Copy link
Contributor

Fixes #1139.

This issue appears to be caused by the parseTextToLines routine when it is grouping teble cells to handle line breaks. There is a comment to flush the line buffer, but it just pushes more lines to the inputLines1 array without resetting the newLine buffer, resulting in the duplication when an array is supplied in the text field without a breakline parameter.

@gitbrent
Copy link
Owner

gitbrent commented Aug 9, 2022

Thanks @mikemeerschaert

Patches need to be against the code src/*.ts files. Files under dist are generated.

See other recent pull requests for examples.

@mikemeerschaert
Copy link
Contributor Author

Sorry about that @gitbrent, I removed the auto-generated files.

@gitbrent gitbrent self-assigned this Aug 21, 2022
@gitbrent gitbrent added this to the 3.12.0 milestone Aug 21, 2022
@gitbrent
Copy link
Owner

@mikemeerschaert - can you provide a test case demonstrating the issue being patched?

@mikemeerschaert
Copy link
Contributor Author

@gitbrent I linked an example repo with a test case in #1139, you can see the bug in this repo

@treystout
Copy link

bumping for interest. Hitting this exact case in latest. It's a bummer losing individual options per text node, what does this request need for merge?

@mikemeerschaert
Copy link
Contributor Author

@treystout it looks like this is in the 3.12.0 milestone, so I think we just need to wait for @gitbrent to find the time to release that version.

@gitbrent gitbrent merged commit 7306661 into gitbrent:master Feb 9, 2023
@gitbrent
Copy link
Owner

gitbrent commented Feb 9, 2023

Thanks @mikemeerschaert !

@mikemeerschaert mikemeerschaert deleted the fix branch February 15, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoPage duplicates text when text array is used
3 participants