read/wasm: support symbol table in linking section #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to handle sections in a different order from which they appear in the file.
This is possible now that we don't have to follow the section order.
|
I don't know enough about the format to review this, but with this change the results from |
|
Thanks for checking. Was there some other project you wanted to use this in that needs this? |
|
I only have an extremely trivial use of replacing some nm-based scripting, and was surprised that wasm was failing rust-lang/compiler-builtins#828. Nothing that can't wait for a release, if that's what you were asking, but thank you for getting this working so quickly. |
|
@philipc would it be possible to do a release that includes this? |
|
Published in 0.37.0 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial support for #471 (The linking section contains other information that might also be useful but isn't supported yet.)