Skip to content

ruby : Add ruby binding for max_len #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025

Conversation

adamdebono
Copy link
Contributor

The max_len/ml parameter was missing in the Ruby binding.

@KitaitiMakoto KitaitiMakoto changed the title Add ruby binding for max_len ruby : Add ruby binding for max_len Aug 6, 2025
@KitaitiMakoto
Copy link
Collaborator

@adamdebono
Thank you! Seems almost okay. I added a comment, and can you add test for max_len in test_params.rb?

@adamdebono
Copy link
Contributor Author

Thanks @KitaitiMakoto I've made those changes.

I wasn't able to get the tests running so I haven't confirmed if they pass, although I've reused the same code as the other tests so I assume they do.

I am attempting to use rake test as is mentioned in the readme, but I'm getting a segfault. I've attached the log, but it looks like the problem is in test_callback.rb#125 - I had noticed I was getting a segfault in my application if I attempted to set that multiple times, presumably this is the same problem.

rake_test.log

@KitaitiMakoto
Copy link
Collaborator

Ah, that segfault is caused by Ruby 3.4.1's bug. Tests should succeed for Ruby 3.4.2 or later.

Your code has no problem. Will merge it.

@KitaitiMakoto KitaitiMakoto merged commit 4245c77 into ggml-org:master Aug 7, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants