Skip to content

Conversation

CISC
Copy link
Collaborator

@CISC CISC commented Aug 17, 2025

Merged all cont+reshape_*d into cont_*d and remove unnecessary ggml_cont in mtmd.

@CISC CISC requested a review from ggerganov August 17, 2025 20:07
@CISC CISC changed the title llama : remove unnecessary conts and merge reshapes llama : merge conts and reshapes and remove unnecessary cont Aug 18, 2025
@CISC
Copy link
Collaborator Author

CISC commented Aug 18, 2025

Note: I did see this #13097 (comment) about the ggml_cont I removed, but the issue has either since been resolved, or it was just a mix-up during implementation refactoring. I have tested Pixtral (on CUDA) with this change, and it works fine.

@CISC CISC merged commit baa9255 into master Aug 18, 2025
47 checks passed
@CISC CISC deleted the cisc/remove-unnecessary-conts-part2 branch August 18, 2025 17:30
@CISC
Copy link
Collaborator Author

CISC commented Aug 18, 2025

@ggerganov Hmmm, two 124 failures in a row for ggml-100-mac-m4:
https://github.com/ggml-org/ci/tree/results/llama.cpp/ba/a9255a45105d2d3b4ec432af13b7a6eda3ff35/ggml-100-mac-m4

I can't find where it fails though, but seems to be related to Pythia tests...

@CISC
Copy link
Collaborator Author

CISC commented Aug 19, 2025

@ggerganov Hmmm, two 124 failures in a row for ggml-100-mac-m4: https://github.com/ggml-org/ci/tree/results/llama.cpp/ba/a9255a45105d2d3b4ec432af13b7a6eda3ff35/ggml-100-mac-m4

I can't find where it fails though, but seems to be related to Pythia tests...

Looking at the stdall log it looks like it dies right at the point where it downloads wikitext, so probably not an actual issue with the test. Weird that it's only failing for ggml-100-mac-m4 though?

@ggerganov
Copy link
Member

I'm looking into this - thanks for noticing. It's not related to the code, just the internet connection issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants