Skip to content

vulkan: Support ne[3]>1 in noncontig matrix-vector multiply #15015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2025
Merged

vulkan: Support ne[3]>1 in noncontig matrix-vector multiply #15015

merged 1 commit into from
Aug 2, 2025

Conversation

jeffbolznv
Copy link
Collaborator

Fixes #15006.

@jeffbolznv jeffbolznv requested a review from 0cc4m as a code owner August 1, 2025 16:43
@github-actions github-actions bot added testing Everything test related Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Aug 1, 2025
ggerganov
ggerganov approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly on my end.

0cc4m
0cc4m approved these changes Aug 2, 2025
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0cc4m 0cc4m merged commit ec0b188 into ggml-org:master Aug 2, 2025
46 of 47 checks passed
@ggerganov
Copy link
Member

ggerganov commented Aug 2, 2025 •
edited
Loading

The new MUL_MAT tests seem to have triggered some failure paths in the CUDA and SYCL backends:

cc @JohannesGaessler, @qnixsynapse for viz

@JohannesGaessler JohannesGaessler mentioned this pull request Aug 2, 2025
Closed
@JohannesGaessler
Copy link
Collaborator

CUDA fix: #15037

@ggerganov ggerganov mentioned this pull request Aug 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

@0cc4m 0cc4m 0cc4m approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning testing Everything test related Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug : Vulkan multi-stream attention problem
4 participants
@jeffbolznv @ggerganov @JohannesGaessler @0cc4m