llama : enable LLAMA_SET_ROWS=1 by default #14959
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
force-pushed
the
gg/llama-set-rows-default
branch
from
34bfbb3 to
6ec2194
Compare
ggerganov
force-pushed
the
gg/llama-set-rows-default
branch
from
6ec2194 to
995b8b1
Compare
ggerganov
force-pushed
the
gg/tests-update-for-set-rows
branch
from
e1ebdea to
d6233d6
Compare
ggerganov
force-pushed
the
gg/llama-set-rows-default
branch
from
995b8b1 to
580d68b
Compare
|
Planning to merge this after #15006 is fixed. The feature should be now robust enough for general usage. |
ggerganov
force-pushed
the
gg/llama-set-rows-default
branch
from
580d68b to
07ad68e
Compare
This was referenced Aug 3, 2025
Nexesenex
pushed a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Aug 5, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Aug 5, 2025
This reverts commit 69ea8ec.
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Aug 5, 2025
This reverts commit 69ea8ec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target #14961
This makes the "set rows" path the default (see #14285 for more info). Operator coverage: #14661
For now we keep the old path via
LLAMA_SET_ROWS=0as a fallback in case we encounter problems. Eventually, when things become stable, the flag will be removed and the code simplified.