-
Notifications
You must be signed in to change notification settings - Fork 1.1k
DXIL & HLSL passthrough #7831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXIL & HLSL passthrough #7831
Conversation
So tests are allowed to assume that all of the vulkan sdk is in path, so the test can shell out to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, some comments
Co-authored-by: Connor Fitzgerald <[email protected]>
@cwfitzgerald Everything should be addressed! |
Connections
#7515
Description
This PR adds support for HLSL and DXIL passthrough. This should also move us slightly more towards a precompiled-shader future.
Testing
No tests at the moment. This is the same as MSL. I can add some in the future. However, I don't know how I should store the compiled DXIL in tree. It seems like bad policy to store arbitrary DXIL blobs, but there is no assembly-like thing, which is what I would use for SPIR-V.
Squash or Rebase?
Squash pls
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.