Skip to content

DXIL & HLSL passthrough #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 25, 2025

Conversation

SupaMaggie70Incorporated
Copy link
Contributor

@SupaMaggie70Incorporated SupaMaggie70Incorporated commented Jun 19, 2025

Connections
#7515

Description
This PR adds support for HLSL and DXIL passthrough. This should also move us slightly more towards a precompiled-shader future.

Testing
No tests at the moment. This is the same as MSL. I can add some in the future. However, I don't know how I should store the compiled DXIL in tree. It seems like bad policy to store arbitrary DXIL blobs, but there is no assembly-like thing, which is what I would use for SPIR-V.

Squash or Rebase?
Squash pls

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@SupaMaggie70Incorporated SupaMaggie70Incorporated marked this pull request as ready for review June 19, 2025 21:05
@SupaMaggie70Incorporated SupaMaggie70Incorporated requested a review from a team as a code owner June 19, 2025 21:05
@cwfitzgerald
Copy link
Member

However, I don't know how I should store the compiled DXIL in tree. It seems like bad policy to store arbitrary DXIL blobs, but there is no assembly-like thing, which is what I would use for SPIR-V.

So tests are allowed to assume that all of the vulkan sdk is in path, so the test can shell out to dxc to compile HLSL in-tree to DXIL - this way too a single source can be used for both tests.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some comments

@SupaMaggie70Incorporated
Copy link
Contributor Author

@cwfitzgerald Everything should be addressed!

@cwfitzgerald cwfitzgerald merged commit e40e66d into gfx-rs:trunk Jun 25, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants