Skip to content

Add binding number to related error messages #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almarklein merged 1 commit into from
Aug 26, 2025
Merged

Add binding number to related error messages #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/conv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,10 @@ pub fn map_bind_group_layout_entry(
native::WGPUTextureSampleType_Depth => wgt::TextureSampleType::Depth,
native::WGPUTextureSampleType_Sint => wgt::TextureSampleType::Sint,
native::WGPUTextureSampleType_Uint => wgt::TextureSampleType::Uint,
_ => panic!("invalid sample type for texture binding layout"),
_ => panic!(
"invalid sample type for texture binding layout at binding {}",
entry.binding
),
},
view_dimension: match entry.texture.viewDimension {
native::WGPUTextureViewDimension_1D => wgt::TextureViewDimension::D1,
Expand All @@ -1435,7 +1438,10 @@ pub fn map_bind_group_layout_entry(
native::WGPUTextureViewDimension_Cube => wgt::TextureViewDimension::Cube,
native::WGPUTextureViewDimension_CubeArray => wgt::TextureViewDimension::CubeArray,
native::WGPUTextureViewDimension_3D => wgt::TextureViewDimension::D3,
_ => panic!("invalid texture view dimension for texture binding layout"),
_ => panic!(
"invalid texture view dimension for texture binding layout at binding {}",
entry.binding
),
},
multisampled: entry.texture.multisampled != 0,
}
Expand All @@ -1450,7 +1456,10 @@ pub fn map_bind_group_layout_entry(
native::WGPUSamplerBindingType_Comparison => {
wgt::BindingType::Sampler(wgt::SamplerBindingType::Comparison)
}
_ => panic!("invalid sampler binding type for sampler binding layout"),
_ => panic!(
"invalid sampler binding type for sampler binding layout at binding {}",
entry.binding
),
}
} else if is_storage_texture {
wgt::BindingType::StorageTexture {
Expand All @@ -1466,7 +1475,7 @@ pub fn map_bind_group_layout_entry(
native::WGPUTextureViewDimension_CubeArray => wgt::TextureViewDimension::CubeArray,
native::WGPUTextureViewDimension_3D => wgt::TextureViewDimension::D3,
_ => {
panic!("invalid texture view dimension for storage texture binding layout")
panic!("invalid texture view dimension for storage texture binding layout at binding {}", entry.binding)
}
},
}
Expand All @@ -1482,7 +1491,10 @@ pub fn map_bind_group_layout_entry(
native::WGPUBufferBindingType_ReadOnlyStorage => {
wgt::BufferBindingType::Storage { read_only: true }
}
_ => panic!("invalid buffer binding type for buffer binding layout"),
_ => panic!(
"invalid buffer binding type for buffer binding layout at binding {}",
entry.binding
),
},
has_dynamic_offset: entry.buffer.hasDynamicOffset != 0,
min_binding_size: {
Expand Down
Loading