Fix read-only depth/stencil attachments #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read-only depth/stencil attachments must have load/store ops None (or _Undefined enum value in C API). However, when converting WGPURenderPassDepthStencilAttachment, WGPULoadOp_Undefined was being mapped to Some(wgc::command::LoadOp::Load) rather than None. Same for store op.
Contributor
|
Bumping this. The current code makes it impossible to use depth_read_only and stencil_read_only. This review fixes that. |
almarklein
approved these changes
Aug 9, 2025
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read-only depth/stencil attachments must have load/store ops None (or _Undefined enum value in C API). However, when converting WGPURenderPassDepthStencilAttachment, WGPULoadOp_Undefined was being mapped to Some(wgc::command::LoadOp::Load) rather than None. Same for store op.