Skip to content

goreleaser: remove checksums.{txt,pem,sig} artifacts #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

goreleaser: remove checksums.{txt,pem,sig} artifacts #1643

wants to merge 1 commit into from

Conversation

duthils
Copy link
Contributor

@duthils duthils commented Oct 7, 2024

This PR is open as an alternative to the PR #1588 to fix the issue #1539.

Changes in this PR imply the following downsides:

  • any automated integrity checks for sops releases that are based on checksums.txt will stop working in the next release
  • there is no documentation to verify integrity while being offline
    • it is possible, but it must be documented if deemed important enough
    • For the record, a command like this can be used for offline checksum verification:
    jq -r .payload sops-v*.intoto.jsonl | base64 -d | jq -r '.subject[] | .digest.sha256 + " " + .name' | sha256sum -c --ignore-missing

@duthils
goreleaser: remove checksums.{txt,pem,sig} artifacts
1097e7a 
Why:

* SLSA verification implies integrity verification, making the checksums file
  redundant
* The checksums file is lacking entries for package files

Signed-off-by: Sebastien Duthil <[email protected]>
@duthils duthils mentioned this pull request Oct 7, 2024
Open
@qg-m-kondratenko qg-m-kondratenko mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@duthils