Skip to content

ref(sdk): Use top-level get_current_scope #93017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

szokeasaurusrex
Copy link
Member

Using sentry_sdk.Scope.get_current_scope has been deprecated in favor of sentry_sdk.get_current_scope.

Going forward, we generally would like SDK users to stick to the top-level APIs.

Split off from #92011.

Stacked on:

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

This parameter is deprecated as of Sentry SDK 2.0.0; the default value is now `True`, so passing this parameter is no longer needed.
Using `sentry_sdk.Scope.get_current_scope` has been deprecated in favor of `sentry_sdk.get_current_scope`.

Going forward, we generally would like SDK users to stick to the top-level APIs.

Split off from #92011.
@szokeasaurusrex szokeasaurusrex requested review from a team as code owners June 6, 2025 13:22
@szokeasaurusrex szokeasaurusrex changed the title Szokeasaurusrex/get_current_scope ref(sdk): Use top-level get_current_scope Jun 6, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/cache/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93017      +/-   ##
==========================================
- Coverage   87.89%   87.88%   -0.01%     
==========================================
  Files       10294    10293       -1     
  Lines      590765   590760       -5     
  Branches    22974    22974              
==========================================
- Hits       519240   519217      -23     
- Misses      71078    71096      +18     
  Partials      447      447              

Base automatically changed from szokeasaurusrex/propagate-hub to master June 6, 2025 13:55
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szokeasaurusrex szokeasaurusrex merged commit 253c147 into master Jun 6, 2025
61 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/get_current_scope branch June 6, 2025 14:51
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Using `sentry_sdk.Scope.get_current_scope` has been deprecated in favor
of `sentry_sdk.get_current_scope`.

Going forward, we generally would like SDK users to stick to the
top-level APIs.

Split off from #92011.

Stacked on:
  - #93016

<!-- Describe your PR here. -->

<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants