ref: Rename set_span_data to set_span_attribute
#92946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`with sentry_sdk.init` is deprecated and will be removed in Sentry SDK 3.0. Split off from #92011
`sentry_sdk.Span.set_data` will be replaced with `sentry_sdk.Span.set_attribute` in Sentry SDK 3.0. This change renames the `set_span_data` method to `set_span_attribute` to match the new method name in the SDK. Split off from #92011
github-actions
bot
added
the
Scope: Backend
loewenheim
approved these changes
Jun 5, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92946 +/- ##
=======================================
Coverage 87.89% 87.90%
=======================================
Files 10284 10284
Lines 590365 590316 -49
Branches 22961 22947 -14
=======================================
- Hits 518917 518895 -22
+ Misses 71001 70974 -27
Partials 447 447 |
shellmayr
pushed a commit
that referenced
this pull request
Jun 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentry_sdk.Span.set_datawill be replaced withsentry_sdk.Span.set_attributein Sentry SDK 3.0.This change renames the
set_span_datamethod toset_span_attributeto match the new method name in the SDK.Split off from #92011
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.