Skip to content

feat(github-comments): Don't comment info-level issues on merged PRs #66110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iamrajjoshi
Copy link
Member

@iamrajjoshi iamrajjoshi commented Feb 29, 2024

  • Added additional filter to prevent comments for info level issues on merged issues.
  • Prevented the trigger of the comment workflow
  • Added additional expression in the WHERE clause of snuba query
  • Wrote tests for both changes

Fixes: https://github.com/getsentry/team-core-product-foundations/issues/126

@iamrajjoshi iamrajjoshi requested review from a team as code owners February 29, 2024 23:17
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 29, 2024
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some nits

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (3c45415) to head (b09469e).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #66110    +/-   ##
========================================
  Coverage   84.25%   84.26%            
========================================
  Files        5293     5294     +1     
  Lines      236792   236917   +125     
  Branches    41007    41030    +23     
========================================
+ Hits       199513   199627   +114     
- Misses      37060    37071    +11     
  Partials      219      219            
Files Coverage Δ
src/sentry/tasks/commit_context.py 99.18% <100.00%> (+0.01%) ⬆️
src/sentry/tasks/integrations/github/pr_comment.py 100.00% <ø> (ø)

... and 18 files with indirect coverage changes

Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iamrajjoshi iamrajjoshi merged commit b83b092 into master Mar 1, 2024
@iamrajjoshi iamrajjoshi deleted the raj/github-comments/do-not-comment-info-level-issues branch March 1, 2024 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants