Skip to content

fix(hybridcloud) Don't use integration proxy for slack #65861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

markstory
Copy link
Member

Slack doesn't use refresh tokens and thus doesn't need to go through the integration proxy as there are no refresh tokens to coordinate.

Slack doesn't use refresh tokens and thus doesn't need to go through the
integration proxy as there are no refresh tokens to co-ordinate.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 27, 2024
@markstory markstory requested a review from a team February 27, 2024 03:53
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (2906703) to head (e27b3ba).
Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #65861      +/-   ##
==========================================
- Coverage   84.25%   84.24%   -0.02%     
==========================================
  Files        5294     5296       +2     
  Lines      236784   236663     -121     
  Branches    41003    40968      -35     
==========================================
- Hits       199506   199376     -130     
- Misses      37059    37068       +9     
  Partials      219      219              
Files Coverage Δ
src/sentry/integrations/slack/client.py 90.76% <100.00%> (-3.35%) ⬇️
src/sentry/integrations/slack/integration.py 95.45% <100.00%> (+1.33%) ⬆️

... and 58 files with indirect coverage changes

@markstory markstory marked this pull request as ready for review February 29, 2024 15:42
@markstory markstory requested a review from a team as a code owner February 29, 2024 15:42
@markstory markstory merged commit 0daa386 into master Mar 1, 2024
@markstory markstory deleted the fix-no-proxy-slack branch March 1, 2024 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants