fix(eap): Format timestamp filters correctly as strings arent accepted (#93604)

EAP no longer accepts string values for timestamp filters. Convert them
to floats.

Fixes SENTRY-3WBY

Author: Zylphrex

src/sentry/search/eap/columns.py

@@ -427,8 +427,11 @@ def simple_measurements_field(
     )
 
 
-def datetime_processor(datetime_string: str) -> str:
-    return datetime.fromisoformat(datetime_string).replace(tzinfo=tz.tzutc()).isoformat()
+def datetime_processor(datetime_value: str | float) -> str:
+    if isinstance(datetime_value, float):
+        # assumes that the timestamp is in seconds
+        return datetime.fromtimestamp(datetime_value).replace(tzinfo=tz.tzutc()).isoformat()
+    return datetime.fromisoformat(datetime_value).replace(tzinfo=tz.tzutc()).isoformat()
 
 
 def project_context_constructor(column_name: str) -> Callable[[SnubaParams], VirtualColumnContext]:

src/sentry/search/eap/resolver.py

@@ -666,12 +666,19 @@ def _resolve_search_value(
                 if operator in constants.IN_OPERATORS:
                     if isinstance(value, list):
                         return AttributeValue(
-                            val_double_array=DoubleArray(values=[val for val in value])
+                            val_double_array=DoubleArray(
+                                values=[
+                                    val.timestamp() if isinstance(val, datetime) else val
+                                    for val in value
+                                ]
+                            )
                         )
                     else:
                         raise InvalidSearchQuery(
                             f"{value} is not a valid value for doing an IN filter"
                         )
+                elif isinstance(value, datetime):
+                    return AttributeValue(val_double=value.timestamp())
                 elif isinstance(value, float):
                     return AttributeValue(val_double=value)
             elif column_type == constants.BOOLEAN:

src/sentry/search/eap/spans/attributes.py

@@ -210,6 +210,7 @@
         ResolvedAttribute(
             public_alias="timestamp",
             internal_name="sentry.timestamp",
+            internal_type=constants.DOUBLE,
             search_type="string",
             processor=datetime_processor,
         ),

tests/sentry/search/eap/test_spans.py

@@ -1,4 +1,5 @@
 import os
+from datetime import datetime
 
 import pytest
 from sentry_protos.snuba.v1.endpoint_trace_item_table_pb2 import (
@@ -138,9 +139,11 @@ def test_timestamp_relative_filter(self):
             where, having, _ = self.resolver.resolve_query("timestamp:-24h")
             assert where == TraceItemFilter(
                 comparison_filter=ComparisonFilter(
-                    key=AttributeKey(name="sentry.timestamp", type=AttributeKey.Type.TYPE_STRING),
+                    key=AttributeKey(name="sentry.timestamp", type=AttributeKey.Type.TYPE_DOUBLE),
                     op=ComparisonFilter.OP_GREATER_THAN_OR_EQUALS,
-                    value=AttributeValue(val_str="2018-12-10 10:20:00+00:00"),
+                    value=AttributeValue(
+                        val_double=datetime.fromisoformat("2018-12-10 10:20:00+00:00").timestamp()
+                    ),
                 )
             )
             assert having is None

tests/snuba/api/endpoints/test_organization_events_span_indexed.py

@@ -5515,3 +5515,65 @@ def test_file_extension(self):
         assert data[0]["file_extension"] == "css"
         assert data[1]["file_extension"] == "js"
         assert meta["dataset"] == self.dataset
+
+    def test_filter_timestamp(self):
+        one_day_ago = before_now(days=1).replace(microsecond=0)
+        three_days_ago = before_now(days=3).replace(microsecond=0)
+
+        span1 = self.create_span({}, start_ts=one_day_ago)
+        span2 = self.create_span({}, start_ts=three_days_ago)
+        self.store_spans([span1, span2], is_eap=self.is_eap)
+
+        request = {
+            "field": ["timestamp"],
+            "project": self.project.id,
+            "dataset": self.dataset,
+        }
+
+        response = self.do_request(
+            {
+                **request,
+                "query": "timestamp:-2d",
+            }
+        )
+        assert response.status_code == 200, response.content
+        assert response.data["data"] == [
+            {
+                "id": span1["span_id"],
+                "project.name": self.project.slug,
+                "timestamp": one_day_ago.isoformat(),
+            },
+        ]
+
+        timestamp = before_now(days=2).isoformat()
+        timestamp = timestamp.split("T", 2)[0]
+
+        response = self.do_request(
+            {
+                **request,
+                "query": f"timestamp:>{timestamp}",
+            }
+        )
+        assert response.status_code == 200, response.content
+        assert response.data["data"] == [
+            {
+                "id": span1["span_id"],
+                "project.name": self.project.slug,
+                "timestamp": one_day_ago.isoformat(),
+            },
+        ]
+
+        response = self.do_request(
+            {
+                **request,
+                "query": f"timestamp:<{timestamp}",
+            }
+        )
+        assert response.status_code == 200, response.content
+        assert response.data["data"] == [
+            {
+                "id": span2["span_id"],
+                "project.name": self.project.slug,
+                "timestamp": three_days_ago.isoformat(),
+            },
+        ]