chore(sentry-apps): Allow Sentry App tokens to appear on group activity payload (#93078)

Requires #93612

In the event a token issued from a sentry app is used to create an
activity, we attribute it to the proxy user instead of a sentry app.

<img width="512" alt="image"
src="https://github.com/user-attachments/assets/de959330-bc0a-4476-803e-3c33e28d0764"
/>

To get the sentry app to appear (and minimize API/RPC calls) I added a
new rpc method that will return the sentry app, and its avatars
(everything the FE will need) to properly render the source of the
activity.


Thinking about this more, I would rather read `is_sentry_app` off of the
user property, so I will modify the RPC method to do that instead of
using all user_ids.

Author: leeandher

src/sentry/api/serializers/models/activity.py

@@ -4,6 +4,9 @@
 from sentry.models.commit import Commit
 from sentry.models.group import Group
 from sentry.models.pullrequest import PullRequest
+from sentry.sentry_apps.api.serializers.sentry_app_avatar import SentryAppAvatarSerializer
+from sentry.sentry_apps.services.app import app_service
+from sentry.sentry_apps.services.app.model import RpcSentryApp
 from sentry.types.activity import ActivityType
 from sentry.users.services.user.serial import serialize_generic_user
 from sentry.users.services.user.service import user_service
@@ -26,6 +29,22 @@ def get_attrs(self, item_list, user, **kwargs):
             )
         users = {u["id"]: u for u in user_list}
 
+        # If an activity is created by the proxy user of a Sentry App, attach it to the payload
+        sentry_apps_list: list[RpcSentryApp] = []
+        if user_ids:
+            sentry_apps_list = app_service.get_sentry_apps_by_proxy_users(proxy_user_ids=user_ids)
+        # Minimal Sentry App serialization to keep the payload minimal
+        sentry_apps = {
+            str(app.proxy_user_id): {
+                "id": str(app.id),
+                "name": app.name,
+                "slug": app.slug,
+                "avatars": serialize(app.avatars, user, serializer=SentryAppAvatarSerializer()),
+            }
+            for app in sentry_apps_list
+            if app.proxy_user_id
+        }
+
         commit_ids = {
             i.data["commit"]
             for i in item_list
@@ -85,6 +104,7 @@ def get_attrs(self, item_list, user, **kwargs):
         return {
             item: {
                 "user": users.get(str(item.user_id)) if item.user_id else None,
+                "sentry_app": sentry_apps.get(str(item.user_id)) if item.user_id else None,
                 "source": (
                     groups.get(item.data["source_id"])
                     if item.type == ActivityType.UNMERGE_DESTINATION.value
@@ -121,6 +141,7 @@ def serialize(self, obj, attrs, user, **kwargs):
         return {
             "id": str(obj.id),
             "user": attrs["user"],
+            "sentry_app": attrs["sentry_app"],
             "type": obj.get_type_display(),
             "data": data,
             "dateCreated": obj.datetime,

tests/sentry/api/serializers/test_activity.py

@@ -3,8 +3,11 @@
 from sentry.models.commit import Commit
 from sentry.models.group import GroupStatus
 from sentry.models.pullrequest import PullRequest
+from sentry.silo.base import SiloMode
 from sentry.testutils.cases import TestCase
+from sentry.testutils.silo import assume_test_silo_mode
 from sentry.types.activity import ActivityType
+from sentry.users.models.user import User
 
 
 class GroupActivityTestCase(TestCase):
@@ -150,3 +153,53 @@ def test_collapse_group_stats_in_activity_with_option(self):
         serialized = serialize(act)
 
         assert "firstSeen" not in serialized["data"]["source"]
+
+    def test_get_activities_for_group_proxy_user(self):
+        project = self.create_project(name="test_activities_group")
+        group = self.create_group(project)
+        user = self.create_user()
+        data = serialize(
+            Activity.objects.create_group_activity(
+                group=group,
+                type=ActivityType.NOTE,
+                data={"text": "A human sent this message"},
+                user=user,
+            )
+        )
+        # Regular users, have a new empty key
+        assert data["user"]["name"] == user.username
+        assert data["sentry_app"] is None
+
+        sentry_app = self.create_sentry_app(name="test_sentry_app")
+        default_avatar = self.create_sentry_app_avatar(sentry_app=sentry_app)
+        upload_avatar = self.create_sentry_app_avatar(sentry_app=sentry_app)
+        with assume_test_silo_mode(SiloMode.CONTROL):
+            proxy_user = User.objects.get(id=sentry_app.proxy_user_id)
+            upload_avatar.avatar_type = 1  # an upload
+            upload_avatar.color = True  # a logo
+            upload_avatar.save()
+
+        data = serialize(
+            Activity.objects.create_group_activity(
+                group=group,
+                type=ActivityType.NOTE,
+                data={"text": "My app sent this message"},
+                user=proxy_user,
+            )
+        )
+        assert data["user"]["name"] == proxy_user.username
+        assert data["sentry_app"]["name"] == sentry_app.name
+        assert {
+            "avatarType": "default",
+            "avatarUuid": default_avatar.ident,
+            "avatarUrl": f"http://testserver/sentry-app-avatar/{default_avatar.ident}/",
+            "color": False,
+            "photoType": "icon",
+        } in data["sentry_app"]["avatars"]
+        assert {
+            "avatarType": "upload",
+            "avatarUuid": upload_avatar.ident,
+            "avatarUrl": f"http://testserver/sentry-app-avatar/{upload_avatar.ident}/",
+            "color": True,
+            "photoType": "logo",
+        } in data["sentry_app"]["avatars"]