-
Notifications
You must be signed in to change notification settings - Fork 180
Make TracingDriverForV32 implements VersionAwarePlatformDriver to handle platform version #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TracingDriverForV32 implements VersionAwarePlatformDriver to handle platform version #731
Conversation
We need to implement the method without implementing the interface, otherwise we trigger again the deprecation. Please also add some tests for the new method 🙏 |
✅ Not sure about the second test I've used the |
Since the whole point of this class is to decouple from the |
I choose to create a fake interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a small nitpick, it looks good to me. Do you mind testing that it works well in your project and confirm it?
…dle platform version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thank you!
Thanks @ste93cry for your help 🙏🏼 |
Fix #730
As discussed in the issue, I had the
createDatabasePlatformForVersion
method to handle the platform version.